Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Andrea Parri <parri.andrea@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
	Chaitanya Kulkarni <kch@nvidia.com>,
	Damien Le Moal <dlemoal@kernel.org>,
	Keith Busch <kbusch@kernel.org>,
	linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH 2/5] nvmet: zns: don't leak stale memory in zone management receive
Date: Wed, 14 Oct 2026 15:04:31 +0200	[thread overview]
Message-ID: <20261014130431.GA15622@lst.de> (raw)
In-Reply-To: <20261014110001.95212-1-parri.andrea@gmail.com>

On Wed, Oct 14, 2026 at 01:00:00PM +0200, Andrea Parri wrote:
> On Tue, Oct 13, 2026 at 04:25:54PM +0200, Christoph Hellwig wrote:
> > On Mon, Oct 12, 2026 at 04:12:29PM +0200, Andrea Parri wrote:
> > > Tested over the loop, tcp, rdma and fc transports with a zoned
> > > null_blk namespace: before this patch, zone reports carried stale bytes
> > > and a data length larger than NUMD was accepted; with it, reports are
> > > fully initialized and such a length fails with Data SGL Length Invalid.
> > 
> > Can you wire up the reproduce in blktests?
> 
> Sure.  Following Documentation/process/security-bugs.rst I had only
> offered the reproducers on request; since you'd like them in blktests,
> I'll post them to linux-block shortly, unless you'd rather have them
> off-list until the fixes are merged.  One test covers this patch, and
> two more cover the fc and NUMD patches of this series.

I would not consider anything relating nvme except for userspace API
a security issue.  The protocols are clearly not designed for and/or
advertised for untrusted networks.

Just to make it clear, that's not to say we don't want these fixed,
but they are considered robustness fixes and not security issues.



  reply	other threads:[~2026-10-14 13:04 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-12 14:12 [PATCH 0/5] nvmet: fix stale data exposure and ZNS validation Andrea Parri
2026-10-12 14:12 ` [PATCH 1/5] nvmet-fc: only send read data for successful commands Andrea Parri
2026-10-12 14:12 ` [PATCH 2/5] nvmet: zns: don't leak stale memory in zone management receive Andrea Parri
2026-10-13 14:25   ` Christoph Hellwig
2026-10-14 11:00     ` Andrea Parri
2026-10-14 13:04       ` Christoph Hellwig [this message]
2026-10-13 15:47   ` Keith Busch
2026-10-12 14:12 ` [PATCH 3/5] nvmet: zns: reject a NUMD whose byte count wraps Andrea Parri
2026-10-13 14:26   ` Christoph Hellwig
2026-10-14 11:00     ` Andrea Parri
2026-10-12 14:12 ` [PATCH 4/5] nvmet: pci-epf: report transport errors in command completions Andrea Parri
2026-10-13 14:27   ` Christoph Hellwig
2026-10-13 15:12     ` Damien Le Moal
2026-10-14 11:01       ` Andrea Parri
2026-10-14 12:46       ` Niklas Cassel
2026-10-12 14:12 ` [PATCH 5/5] nvmet: pci-epf: require SGLs to match the command data length Andrea Parri
2026-10-13 14:28   ` Christoph Hellwig
2026-10-14 12:47     ` Niklas Cassel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261014130431.GA15622@lst.de \
    --to=hch@lst.de \
    --cc=dlemoal@kernel.org \
    --cc=kbusch@kernel.org \
    --cc=kch@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=parri.andrea@gmail.com \
    --cc=sagi@grimberg.me \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox