From: Christoph Hellwig <hch@lst.de>
To: Avi Weiss <thnkslprpt@gmail.com>
Cc: Keith Busch <kbusch@kernel.org>,
linux-nvme@lists.infradead.org, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH] nvme-tcp: wait for in-flight TLS handshake callback
Date: Wed, 28 Oct 2026 15:57:43 +0100 [thread overview]
Message-ID: <20261028145743.GB15112@lst.de> (raw)
In-Reply-To: <20261022071934.3818224-1-thnkslprpt@gmail.com>
On Thu, Oct 22, 2026 at 10:19:34AM +0300, Avi Weiss wrote:
> When nvme_tcp_start_tls() times out or is interrupted,
> tls_handshake_cancel() can return false after handshake_complete()
> marks the request completed, but before nvme_tcp_tls_done()
> finishes. Error cleanup can then release the queue while the
> callback still accesses it.
>
> Wait for queue->tls_complete when cancellation loses, before
> continuing cleanup. Preserve the original timeout or signal error.
Plase take a look at the Sashiko complaint:
https://sashiko.dev/#/patchset/20261022071934.3818224-1-thnkslprpt%40gmail.com
it looks valid from a quick glance.
next prev parent reply other threads:[~2026-10-28 14:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-22 7:19 [PATCH] nvme-tcp: wait for in-flight TLS handshake callback Avi Weiss
2026-10-22 7:35 ` sashiko-bot
2026-10-23 6:38 ` Hannes Reinecke
2026-10-28 14:57 ` Christoph Hellwig [this message]
2026-10-28 15:27 ` Avi Weiss
2026-10-28 15:35 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261028145743.GB15112@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=hare@suse.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=thnkslprpt@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox