From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B07F606A326 for ; Fri, 6 Nov 2026 10:38:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=XX4BhPpL DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=Dd7/v5kOaW90lY/J3mfzVncVl83A75iokgRPsC8yo1c=; b=XX4BhPpLjGj6X38fS+acS3vjX4 veiCpxh2osg3yHmhWoQxl0IrFOUAB16B46wGmxgfEL/kY/8GZi1KKqkI4PhdFLruBMrFr2/B0fx3e ScmXpgruAFBr41wG8STmnLMTAfAN5xLYiEa5309fOt1hMyvhQXTJzKEbFKAHudFRM7adEMCpYdFVu HbF78DbI8vEcZi781e04cJ1OJTsf0O1RWtLuzJKzi5Hyvx0WiEMFQlAaLPoJdh0R9ubUuJ7EGkjVa rAZHnJn9B6fDGpxAevEipNyv5siDIFb2+9PcFDht9d7f6kmZq4biGZB/XGfRM0WQOd7zb925EdWgr wTsgJESA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xPHKb-0000000By6y-0GDv; Fri, 06 Nov 2026 10:38:01 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xPHKX-0000000By6D-2dtS for linux-nvme@lists.infradead.org; Fri, 06 Nov 2026 10:37:59 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 2EF8468BEB; Fri, 6 Nov 2026 11:37:54 +0100 (CET) Date: Fri, 6 Nov 2026 11:37:54 +0100 From: Christoph Hellwig To: Guixin Liu Cc: Keith Busch , Jens Axboe , Sagi Grimberg , Nilay Shroff , Daniel Wagner , Hannes Reinecke , linux-nvme@lists.infradead.org Subject: Re: [PATCH v2 7/9] nvmet: remove unreachable "pcie" entry from the address family map Message-ID: <20261106103754.GK5453@lst.de> References: <20261106022736.3582824-1-kanie@linux.alibaba.com> <20261106022736.3582824-8-kanie@linux.alibaba.com> X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261106022736.3582824-8-kanie@linux.alibaba.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261106_023757_834736_9964E13C X-CRM114-Status: GOOD ( 13.82 ) X-Spam-Score: -1.9 (-) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" X-Spam-Status: No, score=-10.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On Fri, Nov 06, 2026 at 10:27:34AM +0800, Guixin Liu wrote: > The first entry of nvmet_addr_family[] is never matched: both the > adrfam show and store handlers skip index 0, and the > NVMF_ADDR_FAMILY_PCI type is matched by the "pci" entry further down > the array. Drop the entry and start the iteration at index 0 so the > map no longer needs an explanation for the skipped element. Looks good: Reviewed-by: Christoph Hellwig