From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C585606A329 for ; Fri, 6 Nov 2026 10:39:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=wrWcT9O9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=gaoHfM3wTtwoxj8HG7vLz81hToomm6xkkEefXaJGFa0=; b=wrWcT9O94RVhnqWKwpvnC04J6E e1hKTeeG1u72DlwQq6/Xq9NAnX8Mgn4UI1t0+NBBmsPkA7NT7X+V5pt4ekz7yAKgcA5VlNDtuZnIq cxDkxA1/kbuHH5t4BvBgAoBK6iIpSC4iOElSN109iiJ68vzn+wkn2M/YqVCKIhdN2ks4S8C3vIXgX M+gyc3exa3j6xDl6zsexpZmqqQhkHgHFXK3wN11z+hh+z++8ILRogDtlzpZZroW+iYkN9yBlOlmit yPEMsjrTp+eDV9gNZygRisMqdE5Ks2Lr/X65wugTFi8qPexvdyV9OYP8LuBujm7psGwaV9aywnllf O8OxBwug==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xPHM9-0000000ByPJ-250C; Fri, 06 Nov 2026 10:39:37 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xPHM7-0000000ByOW-37ai for linux-nvme@lists.infradead.org; Fri, 06 Nov 2026 10:39:37 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 6DBD168BEB; Fri, 6 Nov 2026 11:39:32 +0100 (CET) Date: Fri, 6 Nov 2026 11:39:32 +0100 From: Christoph Hellwig To: shao.mingyin@zte.com.cn Cc: kbusch@kernel.org, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 1/2] nvmet: zero out unused data of fixed-size log pages Message-ID: <20261106103932.GA5633@lst.de> References: <20261105215753914RuQA4AVkFtXzpBkieEscY@zte.com.cn> <20261105215759419k4-bV6cgNlque5OLcc4E9@zte.com.cn> X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261105215759419k4-bV6cgNlque5OLcc4E9@zte.com.cn> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261106_023935_953876_48FA4F55 X-CRM114-Status: UNSURE ( 9.64 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -1.9 (-) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 Given none of these are in a fast path, should we simply zero the entire transfer length first? Also please cut down the commit messages a bit to be on-point.