From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A47E3606A334 for ; Mon, 16 Nov 2026 08:45:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=EXntoDFV; dkim=pass (2048-bit key) header.d=yadro.com header.i=@yadro.com header.a=rsa-sha256 header.s=mta-02 header.b=hoXJPo8C; dkim=pass (2048-bit key) header.d=yadro.com header.i=@yadro.com header.a=rsa-sha256 header.s=mta-03 header.b=BtP272eU DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:CC:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=Q/p5cdT16DqEKxyY/aNGzE4KrR5OZR8Sl7QoM7V26FQ=; b=EXntoDFVmiz3ipam2kbLd3531i Vy/L2NNO0S1/0mB+uubkyh2l9Yh7+b+BKmqz9TGQDYkLblgZA5SJDdsUy0V80PYWLrxI6Z0krnv8b E8tB77Rb1s8LIPF8k2klSLUPYEKEqbDe0hgteKiNp7nlCqDUbmmjPVzzGSTyD7OFE3hY0Pl69UVdr I5Lii42hR6iK7OBajxfZJ6sOv7QXRCbYwQ6W0un1b8Ha+p0CI5U6TVn3pfIQYMZR8a3Q+3QKCYGUh dwARi7gbkMlKxONHOuG6vHjfxOk1cL0IsZcR/dtHroALM93ogMmhjGWNoiLAYSudnfLv3lpI0mEfY zBhAE3lg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xSsLU-00000001eeq-2pbu; Mon, 16 Nov 2026 08:45:48 +0000 Received: from mta-01.yadro.com ([195.3.219.148]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xSsLQ-00000001ec3-3HcU; Mon, 16 Nov 2026 08:45:46 +0000 Received: from mta-01.yadro.com (localhost [127.0.0.1]) by mta-01.yadro.com (Postfix) with ESMTP id ACF082000A; Mon, 16 Nov 2026 11:45:36 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 mta-01.yadro.com ACF082000A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yadro.com; s=mta-02; t=1794818736; bh=Q/p5cdT16DqEKxyY/aNGzE4KrR5OZR8Sl7QoM7V26FQ=; h=Date:From:To:Subject:Message-ID:MIME-Version:Content-Type:From; b=hoXJPo8CVJqLylH5WoU5WlmZxAHKmkNlEK/TS9oKOW8GDjdr+U47aKm7jcI+taZ8g QN7JtWDWe7qn2XYaku/s1iQJLo2M6uAxYGduoUmDdCEiL2Tw16yG88CnVFIc2Ue8G/ Pte5FDs6uWtOZn3K+tJLnsRQyMH8UgIhMJs224x2O0p0jjdbvL/rQAVS6ZD2kWMYb2 neivw4jNSH1zBEjl8dbKbVFk90m2ouBNUEOXlnQYyWNhcxiaram98Zme7u3Cg9aBxE 2uA9G9f9jcwa3vzMZvf46D+UDMzhZKOTmHC68wWBeMaGIshePl6VR/I0p65jgxVB/g 0yTqQp0D8eanQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yadro.com; s=mta-03; t=1794818736; bh=Q/p5cdT16DqEKxyY/aNGzE4KrR5OZR8Sl7QoM7V26FQ=; h=Date:From:To:Subject:Message-ID:MIME-Version:Content-Type:From; b=BtP272eUPW/V+k7SW5fkHLG6HCn5BFyU8Jtrpq91E3YHbUrSd+EacfzJ7QBj8iTLj 7pKctUP73yJYMsbQleZ10IeufJA2UzGECJnIX1Du2Y/K6E/r94iYKduvY5ouA2xf0Q moQkram0a+oLV9FkRoWENqooceW3FNu7FPz8l6fYfquZpGp0AvbbcrgMCfDaZvqMRe lWgM8tI40eu8bc1ifAouLoEUmKz/SYx4PMPsn2DUIx/xP3GNw15lf4q2Sj0AS5IjPF ZWzyhfPK4Lx6BnQCzl3lnglDp6gp8eJzDnomdREAl4QnUnGA6CoEv8ycnXfR7BSEXp Ia+B92ZkvB72A== Received: from RTM-EXCH-06.corp.yadro.com (unknown [10.34.9.206]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mta-01.yadro.com (Postfix) with ESMTPS; Mon, 16 Nov 2026 11:45:35 +0300 (MSK) Received: from yadro.com (10.34.9.247) by RTM-EXCH-06.corp.yadro.com (10.34.9.206) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.56; Mon, 16 Nov 2026 11:45:36 +0300 Date: Mon, 16 Nov 2026 11:45:40 +0300 From: Dmitry Bogdanov To: Mohamed Khalfella CC: Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Justin Tee , Naresh Gottumukkala , Paul Ely , Hannes Reinecke , Chaitanya Kulkarni , James Smart , Randy Jennings , Mohamed Khalfella , Daniel Wagner , , , Hannes Reinecke Subject: Re: [PATCH v7 03/17] nvmet: Implement CCR nvme command Message-ID: <20261116084540.GA3655@yadro.com> References: <20261114030454.2836543-1-mkhalfella@purestorage.com> <20261114030454.2836543-4-mkhalfella@purestorage.com> X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20261114030454.2836543-4-mkhalfella@purestorage.com> X-ClientProxiedBy: RTM-EXCH-03.corp.yadro.com (10.34.9.203) To RTM-EXCH-06.corp.yadro.com (10.34.9.206) X-KSMG-AntiPhishing: NotDetected X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 2.1.1.8310, bases: 2026/11/16 06:36:00 #28892114 X-KSMG-AntiVirus-Status: NotDetected, skipped X-KSMG-KATA-Status: Not Scanned X-KSMG-LinksScanning: NotDetected X-KSMG-Message-Action: skipped X-KSMG-Rule-ID: 5 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261116_004545_533762_C0E46E7F X-CRM114-Status: GOOD ( 20.33 ) X-Spam-Score: -2.1 (--) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On Fri, Nov 13, 2026 at 07:04:17PM -0800, Mohamed Khalfella wrote: > > Defined by TP8028 Rapid Path Failure Recovery, CCR (Cross-Controller > Reset) command is an nvme command issued to source controller by > initiator to reset impacted controller. Implement CCR command for linux > nvme target. > > Signed-off-by: Mohamed Khalfella > Reviewed-by: Hannes Reinecke > Reviewed-by: Sagi Grimberg > --- > drivers/nvme/target/admin-cmd.c | 76 ++++++++++++++++++++++++++++++ > drivers/nvme/target/core.c | 83 +++++++++++++++++++++++++++++++++ > drivers/nvme/target/nvmet.h | 13 ++++++ > include/linux/nvme.h | 23 +++++++++ > 4 files changed, 195 insertions(+) > > diff --git a/drivers/nvme/target/admin-cmd.c b/drivers/nvme/target/admin-cmd.c > index 5710ae53eb83..3df9db454db9 100644 > --- a/drivers/nvme/target/admin-cmd.c > +++ b/drivers/nvme/target/admin-cmd.c > @@ -378,6 +378,7 @@ static void nvmet_get_cmd_effects_admin(struct nvmet_ctrl *ctrl, > log->acs[nvme_admin_get_features] = > log->acs[nvme_admin_async_event] = > log->acs[nvme_admin_keep_alive] = > + log->acs[nvme_admin_cross_ctrl_reset] = > cpu_to_le32(NVME_CMD_EFFECTS_CSUPP); > } > > @@ -1629,6 +1630,78 @@ void nvmet_execute_keep_alive(struct nvmet_req *req) > nvmet_req_complete(req, status); > } > > +void nvmet_execute_cross_ctrl_reset(struct nvmet_req *req) > +{ > + struct nvmet_ctrl *ictrl, *sctrl = req->sq->ctrl; > + struct nvme_command *cmd = req->cmd; > + struct nvmet_ccr *ccr, *new_ccr; > + int ccr_active, ccr_total; > + u16 cntlid, status = NVME_SC_SUCCESS; > + > + if (!nvmet_check_transfer_len(req, 0)) > + return; > + > + cntlid = le16_to_cpu(cmd->ccr.icid); > + if (sctrl->cntlid == cntlid) { > + req->error_loc = > + offsetof(struct nvme_cross_ctrl_reset_cmd, icid); > + status = NVME_SC_INVALID_FIELD | NVME_STATUS_DNR; > + goto out; > + } cntlid has to be validated against the configured range of the controller ids (subsys->cntlid_min <= cntlid <= subsys->cntlid_max). That will allow CCR to work correctly on a distributed target. > + > + /* Find and get impacted controller */ > + ictrl = nvmet_ctrl_find_get_ccr(sctrl->subsys, sctrl->hostnqn, > + cmd->ccr.ciu, cntlid, > + le64_to_cpu(cmd->ccr.cirn)); > + if (!ictrl) { > + /* Immediate Reset Successful */ > + nvmet_set_result(req, 1); > + status = NVME_SC_SUCCESS; > + goto out; > + } > +