Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Max Gurtovoy <mgurtovoy@nvidia.com>
Cc: Stephane Thiell <sthiell@hudson-trading.com>,
	linux-nvme@lists.infradead.org, kbusch@kernel.org, hch@lst.de,
	sagi@grimberg.me, axboe@kernel.dk
Subject: Re: [PATCH v2] nvme-rdma: add a module parameter to disable T10-PI offload
Date: Fri, 20 Nov 2026 18:58:32 +0100	[thread overview]
Message-ID: <20261120175832.GA1726@lst.de> (raw)
In-Reply-To: <63f323c5-53bf-475f-808a-b6819b187bb0@nvidia.com>

On Mon, Nov 16, 2026 at 02:59:10AM +0200, Max Gurtovoy wrote:
> IIRC, when we developed this feature, a connect param to control PI offload 
> was part of the initial patchset, but the community didn’t ack it.
> I think that connect param is a better option than the module param.

Yes.

>
> Later (Jan 2024) I proposed a per-connect option, nvme connect 
> --disallow_pi, together with uniform metadata settings for the ns head.
> Some of the code for NS settings was merged in a separate patcheset that 
> didn't include the connect param.
> I believe we can also merge the connect cmdline param (better call it 
> enable_pi and set default to 1 as suggested by the community).
>
> I'll check the status of the old patches internally and update.

Yeah, let's get the rest of this merged.



      reply	other threads:[~2026-11-20 17:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-12 21:01 [PATCH v2] nvme-rdma: add a module parameter to disable T10-PI offload Stephane Thiell
2026-11-16  0:59 ` Max Gurtovoy
2026-11-20 17:58   ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261120175832.GA1726@lst.de \
    --to=hch@lst.de \
    --cc=axboe@kernel.dk \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=mgurtovoy@nvidia.com \
    --cc=sagi@grimberg.me \
    --cc=sthiell@hudson-trading.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox