Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Omar Alzand <omaribrahimfadel@gmail.com>
To: linux-nvme@lists.infradead.org
Cc: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@kernel.dk>,
	Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
	Bean Huo <beanhuo@micron.com>
Subject: [PATCH RESEND] nvme-pci: add NVME_QUIRK_DMAPOOL_ALIGN_512 for Micron 2200
Date: Sat, 21 Nov 2026 23:46:52 +0300	[thread overview]
Message-ID: <20261121204652.16374-1-omaribrahimfadel@gmail.com> (raw)
In-Reply-To: <CALJMncxA-=OFc05Ht74hWnia8-sCd5yLn5hK+KfnoHMO_sbzSQ@mail.gmail.com>

The Micron 2200 (1344:5410) corrupts the last page of reads of exactly
33 pages (132 KiB).  Such a read uses a 32-entry PRP list, which exactly
fills a 256-byte small-pool descriptor, and the final page is dropped
while the read still returns success.  On btrfs this appears as
intermittent "csum failed" read errors that succeed on retry.

A raw-device test (eight O_DIRECT readers of N pages into a 0xAA-filled
buffer, plus mixed-size background load) isolates it to 33-page reads:

  pages   reads    bad pages
     32   23515    0
     33   17715    1001   (all at page 33, ~5.65%)
     34   13735    0

Booting with nvme.quirks=1344:5410:dmapool_align_512 eliminates it
(133280 reads at 33 pages, 0 bad) and clears the btrfs checksum errors.
Splitting the read via max_sectors_kb=128 also avoids it; writes are
unaffected.  This is the same quirk the Micron 4100AT needed.

Verified through the nvme.quirks module parameter on a single 2200V
(Micron_2200V_MTFDHBA512TCK, firmware P1MA0V4); this adds the equivalent
id_table entry.

Suggested-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Omar Alzand <omaribrahimfadel@gmail.com>
---
Resent inline as Christoph asked; the 7 Nov copy was only an attachment.
No changes.  Bean noted the quirk has no functional downside and had no
objection to the 1344:5410 entry.  Applies to v7.4-rc3; checkpatch clean.

 drivers/nvme/host/pci.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 076603df0..2b718cfd7 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -4416,6 +4416,8 @@ static const struct pci_device_id nvme_id_table[] = {
 				NVME_QUIRK_IGNORE_DEV_SUBNQN, },
 	 { PCI_DEVICE(0x1344, 0x5407), /* Micron Technology Inc NVMe SSD */
 		.driver_data = NVME_QUIRK_IGNORE_DEV_SUBNQN },
+	{ PCI_DEVICE(0x1344, 0x5410),	/* Micron 2200 */
+		.driver_data = NVME_QUIRK_DMAPOOL_ALIGN_512, },
 	 { PCI_DEVICE(0x1344, 0x6001),   /* Micron Nitro NVMe */
 		 .driver_data = NVME_QUIRK_BOGUS_NID, },
 	{ PCI_DEVICE(0x1344, 0x6004),	/* Micron 4100AT */
-- 
2.56.0



      parent reply	other threads:[~2026-11-21 20:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-01 21:50 nvme-pci: Micron 2200 (1344:5410) needs NVME_QUIRK_DMAPOOL_ALIGN_512 Omar Alzand
2026-11-04  8:49 ` Christoph Hellwig
     [not found] ` <IA6PR08MB10897D405AB097DF85E193EF8DB682@IA6PR08MB10897.namprd08.prod.outlook.com>
2026-11-07  3:19   ` Omar Alzand
2026-11-21 20:46 ` Omar Alzand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261121204652.16374-1-omaribrahimfadel@gmail.com \
    --to=omaribrahimfadel@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=beanhuo@micron.com \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox