From: Jens Axboe <axboe@kernel.dk>
To: Keith Busch <kbusch@fb.com>,
linux-nvme@lists.infradead.org, hch@lst.de, sagi@grimberg.me
Cc: Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH] nvme: restrict management ioctls to admin
Date: Fri, 9 Sep 2022 08:57:35 -0600 [thread overview]
Message-ID: <20f1789d-3c5e-b1d0-c3dd-d6fffd12b82b@kernel.dk> (raw)
In-Reply-To: <20220908213517.3085323-1-kbusch@fb.com>
On 9/8/22 3:35 PM, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
>
> The passthrough commands already have this restriction, but the other
> operations do not. Require the same capabilities for all users as all of
> these operations can be disruptive.
Would it be saner to require that you have write permissions on the
opened device? Not sure this CAP_SYS_ADMIN is really necessary,
and might break existing setups as this is new.
I do agree that passthrough and sync ioctl based issue should be
consistent, though.
--
Jens Axboe
next prev parent reply other threads:[~2022-09-09 14:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220908214000epcas5p1a9bf63bc35632888248e094daacbcbde@epcas5p1.samsung.com>
2022-09-08 21:35 ` [PATCH] nvme: restrict management ioctls to admin Keith Busch
2022-09-09 13:11 ` Kanchan Joshi
2022-09-09 14:57 ` Jens Axboe [this message]
2022-09-09 15:11 ` Christoph Hellwig
2022-09-12 12:24 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20f1789d-3c5e-b1d0-c3dd-d6fffd12b82b@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@fb.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox