* [PATCH 1/2] nvmet-rdma: Add unlikely for response allocated check
@ 2018-11-19 10:58 Israel Rukshin
2018-11-19 10:58 ` [PATCH 2/2] nvme: Remove unused forward declaration Israel Rukshin
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Israel Rukshin @ 2018-11-19 10:58 UTC (permalink / raw)
Signed-off-by: Israel Rukshin <israelr at mellanox.com>
Reviewed-by: Max Gurtovoy <maxg at mellanox.com>
---
drivers/nvme/target/rdma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/target/rdma.c b/drivers/nvme/target/rdma.c
index 3f7971d3..932242e 100644
--- a/drivers/nvme/target/rdma.c
+++ b/drivers/nvme/target/rdma.c
@@ -196,7 +196,7 @@ static inline bool nvmet_rdma_need_data_out(struct nvmet_rdma_rsp *rsp)
{
unsigned long flags;
- if (rsp->allocated) {
+ if (unlikely(rsp->allocated)) {
kfree(rsp);
return;
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 2/2] nvme: Remove unused forward declaration 2018-11-19 10:58 [PATCH 1/2] nvmet-rdma: Add unlikely for response allocated check Israel Rukshin @ 2018-11-19 10:58 ` Israel Rukshin 2018-11-19 22:39 ` Sagi Grimberg 2018-11-19 22:38 ` [PATCH 1/2] nvmet-rdma: Add unlikely for response allocated check Sagi Grimberg 2018-11-20 9:35 ` Christoph Hellwig 2 siblings, 1 reply; 5+ messages in thread From: Israel Rukshin @ 2018-11-19 10:58 UTC (permalink / raw) Signed-off-by: Israel Rukshin <israelr at mellanox.com> Reviewed-by: Max Gurtovoy <maxg at mellanox.com> --- drivers/nvme/host/core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index 559d567..6b83809 100644 --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -97,7 +97,6 @@ static struct class *nvme_class; static struct class *nvme_subsys_class; -static void nvme_ns_remove(struct nvme_ns *ns); static int nvme_revalidate_disk(struct gendisk *disk); static void nvme_put_subsystem(struct nvme_subsystem *subsys); static void nvme_remove_invalid_namespaces(struct nvme_ctrl *ctrl, -- 1.8.3.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] nvme: Remove unused forward declaration 2018-11-19 10:58 ` [PATCH 2/2] nvme: Remove unused forward declaration Israel Rukshin @ 2018-11-19 22:39 ` Sagi Grimberg 0 siblings, 0 replies; 5+ messages in thread From: Sagi Grimberg @ 2018-11-19 22:39 UTC (permalink / raw) Reviewed-by: Sagi Grimberg <sagi at grimberg.me> ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] nvmet-rdma: Add unlikely for response allocated check 2018-11-19 10:58 [PATCH 1/2] nvmet-rdma: Add unlikely for response allocated check Israel Rukshin 2018-11-19 10:58 ` [PATCH 2/2] nvme: Remove unused forward declaration Israel Rukshin @ 2018-11-19 22:38 ` Sagi Grimberg 2018-11-20 9:35 ` Christoph Hellwig 2 siblings, 0 replies; 5+ messages in thread From: Sagi Grimberg @ 2018-11-19 22:38 UTC (permalink / raw) Reviewed-by: Sagi Grimberg <sagi at grimberg.me> ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] nvmet-rdma: Add unlikely for response allocated check 2018-11-19 10:58 [PATCH 1/2] nvmet-rdma: Add unlikely for response allocated check Israel Rukshin 2018-11-19 10:58 ` [PATCH 2/2] nvme: Remove unused forward declaration Israel Rukshin 2018-11-19 22:38 ` [PATCH 1/2] nvmet-rdma: Add unlikely for response allocated check Sagi Grimberg @ 2018-11-20 9:35 ` Christoph Hellwig 2 siblings, 0 replies; 5+ messages in thread From: Christoph Hellwig @ 2018-11-20 9:35 UTC (permalink / raw) Thanks, applied both patches to nvme-4.21. ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-11-20 9:35 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-11-19 10:58 [PATCH 1/2] nvmet-rdma: Add unlikely for response allocated check Israel Rukshin 2018-11-19 10:58 ` [PATCH 2/2] nvme: Remove unused forward declaration Israel Rukshin 2018-11-19 22:39 ` Sagi Grimberg 2018-11-19 22:38 ` [PATCH 1/2] nvmet-rdma: Add unlikely for response allocated check Sagi Grimberg 2018-11-20 9:35 ` Christoph Hellwig
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).