From mboxrd@z Thu Jan 1 00:00:00 1970 From: axboe@kernel.dk (Jens Axboe) Date: Thu, 29 Nov 2018 10:02:25 -0700 Subject: [PATCH 3/7] nvme: implement mq_ops->commit_rqs() hook In-Reply-To: <20181129154713.GC7234@infradead.org> References: <20181128133538.20329-1-axboe@kernel.dk> <20181128133538.20329-4-axboe@kernel.dk> <20181129154713.GC7234@infradead.org> Message-ID: <2188627d-6d45-fe8a-8d31-fa46fdb82618@kernel.dk> On 11/29/18 8:47 AM, Christoph Hellwig wrote: >> +static inline int nvme_next_ring_index(struct nvme_queue *nvmeq, u16 index) >> +{ >> + if (++index == nvmeq->q_depth) >> + return 0; >> + >> + return index; >> +} > > This is unused now. Huh, wonder how I missed that. GCC must not have complained. > Also what about this little cleanup on top? That looks good, I like it. With that, can I add your reviewed-by? I'll run a sanity check on it first. -- Jens Axboe