From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 48114CFC274 for ; Tue, 15 Oct 2024 08:17:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:References:Cc:To:From:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=La2j6IF9TBm6RF+v96mSbxxFYToqphprBVx5Fr2ZoWY=; b=oAgA9bc6fxnWNUze+i0CH+zwvl rcZG6qX8oT/vFhWWxNIZwAiynKwzekGgd+orWcP4yg0+RtEBcoRABLP+h+NmzeZpIL99hl/CX94GW vCgQrxiyGtnF2N9xsaZU9/6mwW83pngp7ke5+9QBzDyRmcIq1nVOlFHYTUz+9MoO8fsC9D7zQFk+B Qq1JBbvdxXrhQ1gyvRV0Cn502nvZJ1mevj5IBN8IAfuKkEtpMmMn2rzKk7ZL5idlzaQwRpVxxSZ4Q cEGGm82c0oBWC/1iTyHAKTBq+FHVBjAn8ZwZUuAI2Lq2PUfh5Sc3vsuNZgb5HSHIWh4lodnkkc+qK ylpualXQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t0ck6-00000007Tas-1sH9; Tue, 15 Oct 2024 08:17:22 +0000 Received: from out30-101.freemail.mail.aliyun.com ([115.124.30.101]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t0ciO-00000007TEJ-08Il for linux-nvme@lists.infradead.org; Tue, 15 Oct 2024 08:15:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1728980132; h=Message-ID:Date:MIME-Version:Subject:From:To:Content-Type; bh=La2j6IF9TBm6RF+v96mSbxxFYToqphprBVx5Fr2ZoWY=; b=BbQuwizjKhyruzAORgcNTyb4sWFDE6g4RgXaRH/lXIIsxCvUUO2wWcUcYzkGVxVAI9NdrqOjS/+13t+zE49RICxnRXF8tjeUhOR4YOoIf0MA01Hnaizto2boSWvsPFDNaSjhVEbuhuGgk9+rNvn/P6uVfA+joouMoRt+KI82aAU= Received: from 30.178.81.198(mailfrom:kanie@linux.alibaba.com fp:SMTPD_---0WHCnqvZ_1728980130 cluster:ay36) by smtp.aliyun-inc.com; Tue, 15 Oct 2024 16:15:31 +0800 Message-ID: <2263ee49-1c8e-4aa8-9682-fbea57350b13@linux.alibaba.com> Date: Tue, 15 Oct 2024 16:15:28 +0800 MIME-Version: 1.0 User-Agent: =?UTF-8?B?TW96aWxsYSBUaHVuZGVyYmlyZCDmtYvor5XniYg=?= Subject: Re: [PATCH] nvmetcli: reservation configuration support From: Guixin Liu To: hch@lst.de, sagi@grimberg.me, kch@nvidia.com, d.bogdanov@yadro.com Cc: linux-nvme@lists.infradead.org References: <20241008080800.7712-1-kanie@linux.alibaba.com> In-Reply-To: <20241008080800.7712-1-kanie@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241015_011536_285328_37EBF323 X-CRM114-Status: GOOD ( 11.85 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org Hi Christoph,     Could you please take a look at this nvmetcli patch? Best Regards, Guixin Liu 在 2024/10/8 16:08, Guixin Liu 写道: > Add support for reservation configuration. > > Signed-off-by: Guixin Liu > --- > nvmet/nvme.py | 2 +- > nvmetcli | 2 ++ > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/nvmet/nvme.py b/nvmet/nvme.py > index 59efdb5..20b3cca 100644 > --- a/nvmet/nvme.py > +++ b/nvmet/nvme.py > @@ -567,7 +567,7 @@ class Namespace(CFSNode): > if nsid < 1 or nsid > self.MAX_NSID: > raise CFSError("NSID must be 1 to %d" % self.MAX_NSID) > > - self.attr_groups = ['device', 'ana'] > + self.attr_groups = ['device', 'ana', 'resv'] > self._subsystem = subsystem > self._nsid = nsid > self._path = "%s/namespaces/%d" % (self.subsystem.path, self.nsid) > diff --git a/nvmetcli b/nvmetcli > index d949891..6e5348f 100755 > --- a/nvmetcli > +++ b/nvmetcli > @@ -283,6 +283,8 @@ class UINamespaceNode(UINode): > info.append("nguid=" + ns_nguid) > if self.cfnode.grpid != 0: > info.append("grpid=" + str(self.cfnode.grpid)) > + resv_enable = self.cfnode.get_attr("resv", "enable") > + info.append("resv_enable=" + str(resv_enable)) > info.append("enabled" if self.cfnode.get_enable() else "disabled") > ns_enabled = self.cfnode.get_enable() > return (", ".join(info), True if ns_enabled == 1 else ns_enabled)