Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Nitin Rawat (QUIC)" <quic_nitirawa@quicinc.com>
To: "Nitin Rawat (QUIC)" <quic_nitirawa@quicinc.com>,
	Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
	Sagi Grimberg <sagi@grimberg.me>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Cc: "Sajida Bhanu (Temp) (QUIC)" <quic_c_sbhanu@quicinc.com>
Subject: RE: [PATCH v3] nvme/pci: Add quick suspend quirk for Sc7280 Platform
Date: Thu, 10 Feb 2022 20:58:19 +0000	[thread overview]
Message-ID: <229a106182ae4572b3d9b250bfc53db5@quicinc.com> (raw)
In-Reply-To: <1644526408-10834-1-git-send-email-quic_nitirawa@quicinc.com>

Hi Keith,
My Bad..Uploaded wrong patch from my local. I have uploaded the tested patch now.

Regards,
Nitin



-----Original Message-----
From: Nitin Rawat <quic_nitirawa@quicinc.com> 
Sent: Friday, February 11, 2022 2:23 AM
To: Keith Busch <kbusch@kernel.org>; Jens Axboe <axboe@fb.com>; Sagi Grimberg <sagi@grimberg.me>; linux-nvme@lists.infradead.org; linux-kernel@vger.kernel.org
Cc: Nitin Rawat (QUIC) <quic_nitirawa@quicinc.com>; Sajida Bhanu (Temp) (QUIC) <quic_c_sbhanu@quicinc.com>
Subject: [PATCH v3] nvme/pci: Add quick suspend quirk for Sc7280 Platform

Enable quick suspend quirks for Sc7280 platform, where power to nvme device is removed during suspend-resume process. This is done to avoid the failure dring resume.

This enables simple suspend path for this platform.

Signed-off-by: Nitin Rawat <quic_nitirawa@quicinc.com>
Signed-off-by: Shaik Sajida Bhanu <quic_c_sbhanu@quicinc.com>
---

Change from v2-v3:
* changed if/else condition

---

 drivers/nvme/host/pci.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index 6a99ed6..1dff749 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -3034,6 +3034,15 @@ static unsigned long check_vendor_combination_bug(struct pci_dev *pdev)
 			return NVME_QUIRK_SIMPLE_SUSPEND;
 	}

+	if (of_machine_is_compatible("qcom,sc7280")) {
+		/*
+		 * Append quick suspend quirks for sc7280 platforms
+		 * so that simple suspend path is executed for this
+		 * platform to avoid any resume failure.
+		 */
+		return NVME_QUIRK_SIMPLE_SUSPEND;
+	}
+
 	return 0;
 }

--
2.7.4



  parent reply	other threads:[~2022-02-10 20:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-10 20:53 [PATCH v3] nvme/pci: Add quick suspend quirk for Sc7280 Platform Nitin Rawat
2022-02-10 20:57 ` Keith Busch
2022-02-10 20:58 ` Nitin Rawat (QUIC) [this message]
2022-02-11  6:22 ` Christoph Hellwig
2022-02-16 16:07   ` Nitin Rawat (QUIC)
2022-02-16 16:09     ` Nitin Rawat (QUIC)
2022-02-17  2:42       ` Vidya Sagar
2022-02-16 17:12     ` Christoph Hellwig
     [not found]   ` <8b2735c1-4207-dc1b-45bc-33a4138b57cc@quicinc.com>
2022-04-20  7:46     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=229a106182ae4572b3d9b250bfc53db5@quicinc.com \
    --to=quic_nitirawa@quicinc.com \
    --cc=axboe@fb.com \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=quic_c_sbhanu@quicinc.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox