From: Hannes Reinecke <hare@suse.de>
To: Xixin Liu <liuxixin@kylinos.cn>, linux-nvme@lists.infradead.org
Cc: kbusch@kernel.org, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me,
dwagner@suse.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] nvme-tcp: fix wrong status on deferred digest error
Date: Wed, 26 Aug 2026 11:39:34 +0200 [thread overview]
Message-ID: <22ddb116-840d-4d6b-ae2a-5bdb755273df@suse.de> (raw)
In-Reply-To: <1.nvme-tcp-req-status.v1.git.liuxixin@kylinos.cn>
On 8/26/26 3:30 AM, Xixin Liu wrote:
> A C2HData digest error stores a host status code in req status. Without
> DATA_SUCCESS the request is completed later from the rsp path, which
> passed that value straight into complete and could report the wrong
> status code.
>
> Keep req status as a host status code. On the rsp path, shift left when
> a host error was already stored, otherwise use the completion status
> field.
>
I really don't see it. Where is the issue?
AFAICS we're just changing the type of 'status' from holding the
wire-value to the host value.
Can you make the patch simpler by just keeping 'status' as __le16?
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich
next prev parent reply other threads:[~2026-08-26 9:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-26 2:15 [PATCH v1 0/1] nvme-tcp: fix wrong status on deferred digest error Xixin Liu
2026-08-26 1:30 ` [PATCH v1 1/1] " Xixin Liu
2026-08-26 9:39 ` Hannes Reinecke [this message]
2026-08-27 2:40 ` [PATCH v1 0/1] " Xixin Liu
2026-08-27 1:05 ` [PATCH v2 " Xixin Liu
2026-08-27 1:05 ` [PATCH v2 1/1] " Xixin Liu
2026-08-30 21:43 ` Sagi Grimberg
2026-08-31 2:15 ` Xixin Liu
2026-08-31 2:05 ` [PATCH v3 0/1] " Xixin Liu
2026-08-31 2:10 ` [PATCH v3 1/1] " Xixin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22ddb116-840d-4d6b-ae2a-5bdb755273df@suse.de \
--to=hare@suse.de \
--cc=axboe@kernel.dk \
--cc=dwagner@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=liuxixin@kylinos.cn \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox