From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Keith Busch <kbusch@meta.com>
Cc: "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"hch@lst.de" <hch@lst.de>, "sagi@grimberg.me" <sagi@grimberg.me>,
"joshi.k@samsung.com" <joshi.k@samsung.com>,
"axboe@kernel.dk" <axboe@kernel.dk>,
Keith Busch <kbusch@kernel.org>,
Alan Adamson <alan.adamson@oracle.com>,
Daniel Wagner <dwagner@suse.de>
Subject: Re: [PATCHv3] nvme: quiet user passthrough command errors
Date: Fri, 28 Oct 2022 16:49:11 +0000 [thread overview]
Message-ID: <23014EB9-EAD3-4973-9AE8-12B37AA9D508@nvidia.com> (raw)
In-Reply-To: <20221028144435.1613982-1-kbusch@meta.com>
>
> On Oct 28, 2022, at 7:44 AM, Keith Busch <kbusch@meta.com> wrote:
>
> From: Keith Busch <kbusch@kernel.org>
>
> The driver is spamming the kernel logs for entirely harmless errors from
> user space submitting unsupported commands. Just silence the errors.
> The application has direct access to command status, so there's no need
> to log these.
>
> And since every passthrough command now uses the quiet flag, move the
> setting to the common initializer.
>
> Cc: Alan Adamson <alan.adamson@oracle.com>
> Reviewed-by: Daniel Wagner <dwagner@suse.de>
> Reviewed-by: Kanchan Joshi <joshi.k@samsung.com>
> Signed-off-by: Keith Busch <kbusch@kernel.org>
> ---
>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
next prev parent reply other threads:[~2022-10-28 16:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 14:44 [PATCHv3] nvme: quiet user passthrough command errors Keith Busch
2022-10-28 16:49 ` Chaitanya Kulkarni [this message]
2022-10-28 16:51 ` Jens Axboe
2022-10-28 19:08 ` Alan Adamson
2022-10-28 20:07 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23014EB9-EAD3-4973-9AE8-12B37AA9D508@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=alan.adamson@oracle.com \
--cc=axboe@kernel.dk \
--cc=dwagner@suse.de \
--cc=hch@lst.de \
--cc=joshi.k@samsung.com \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox