From: Nilay Shroff <nilay@linux.ibm.com>
To: Mohamed Khalfella <mkhalfella@purestorage.com>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Chaitanya Kulkarni <kch@nvidia.com>,
Keith Busch <kbusch@kernel.org>
Cc: Hannes Reinecke <hare@kernel.org>,
Randy Jennings <randyj@purestorage.com>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvmet: Remove unnecessary assignment to ret in nvmet_ns_enable()
Date: Mon, 28 Jul 2025 09:20:52 +0530 [thread overview]
Message-ID: <237cb015-feed-4c9c-a23e-8c3dc25466ba@linux.ibm.com> (raw)
In-Reply-To: <20250725230639.2017274-1-mkhalfella@purestorage.com>
On 7/26/25 4:36 AM, Mohamed Khalfella wrote:
> Commit 74d16965d7ac ("nvmet-loop: avoid using mutex in IO hotpath")
> moved checking maximum number of namespaces in subsystem from
> nvmet_ns_enable() to nvmet_ns_alloc(). The assignment to ret in
> nvmet_ns_enable() is no longer needed, remove it.
>
> Fixex: 74d16965d7ac ("nvmet-loop: avoid using mutex in IO hotpath")
> Signed-off-by: Mohamed Khalfella <mkhalfella@purestorage.com>
Looks good to me:
Reviewed-by: Nilay Shroff <nilay@linux.ibm.com>
next prev parent reply other threads:[~2025-07-28 3:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-25 23:06 [PATCH] nvmet: Remove unnecessary assignment to ret in nvmet_ns_enable() Mohamed Khalfella
2025-07-28 3:50 ` Nilay Shroff [this message]
2025-07-30 15:53 ` Christoph Hellwig
2025-07-30 16:17 ` Mohamed Khalfella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=237cb015-feed-4c9c-a23e-8c3dc25466ba@linux.ibm.com \
--to=nilay@linux.ibm.com \
--cc=hare@kernel.org \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mkhalfella@purestorage.com \
--cc=randyj@purestorage.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).