From mboxrd@z Thu Jan 1 00:00:00 1970 From: sagi@grimberg.me (Sagi Grimberg) Date: Fri, 17 Aug 2018 15:47:04 -0700 Subject: [PATCH 2/5] nvme: register ns_id attributes as default sysfs groups In-Reply-To: References: <20180814073305.87255-1-hare@suse.de> <20180814073305.87255-3-hare@suse.de> <5a4aab8b5f509d8090ad10107b01d11285fe1528.camel@wdc.com> <20180817070013.GD11170@lst.de> Message-ID: <23e2d972-c1fd-4581-60d1-a3a736f311a8@grimberg.me> > Hello Christoph, > > How about applying the patch below on top of Hannes' patch? The patch below > has the advantage that it completely separates the open channel sysfs > attributes from the NVMe core sysfs attributes - the open channel code > doesn't have to know anything about the NVMe core sysfs attributes and the > NVMe core does not have to know anything about the open channel sysfs > attributes. This looks better to me Bart (unless I'm missing something)