From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1902C433DB for ; Tue, 19 Jan 2021 01:50:51 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1F65A20793 for ; Tue, 19 Jan 2021 01:50:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1F65A20793 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8uOVEaFUz7OxFe9nb70ZiW7irnlBFJumzzuJO67Ppto=; b=fXGWzzyPZFKFzKtDYpEXc4+Kp qdstBpy9ocAk98CgLiuyLo/swAc7RBw11dnPeX8M8M8Y40tTFJeVhMQoxFaxI6pBNpCxJlGkzg1HR fb6x5feUyWFbji6pqCh9OCdxU3UxDxrZ99ZpjnWQn4l5k6QKYDYrnNI3PgSM9YTfE35jXBdS6rEGg 7REMJytGNSRelDHcYmhGuSavfGOg7V5ZHXuJ9Qh9wrhp3jK5yNJJc+d0BCRCSUwrBntr9ejk0R5v/ ZgbMdEwA8b+0tWzaiH/hkrChK7BS/vXdZ5/epPwIkgV6q5Dif3RE5FhSb23LxCD7xTxbWubYt9U3S 6/4Sj/d6A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l1gAC-0002C9-J4; Tue, 19 Jan 2021 01:50:32 +0000 Received: from szxga08-in.huawei.com ([45.249.212.255]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l1gA8-0002AV-1X for linux-nvme@lists.infradead.org; Tue, 19 Jan 2021 01:50:29 +0000 Received: from DGGEMM405-HUB.china.huawei.com (unknown [172.30.72.57]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4DKWlK2W61z13M0X; Tue, 19 Jan 2021 09:48:29 +0800 (CST) Received: from dggema772-chm.china.huawei.com (10.1.198.214) by DGGEMM405-HUB.china.huawei.com (10.3.20.213) with Microsoft SMTP Server (TLS) id 14.3.498.0; Tue, 19 Jan 2021 09:50:16 +0800 Received: from [10.169.42.93] (10.169.42.93) by dggema772-chm.china.huawei.com (10.1.198.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1913.5; Tue, 19 Jan 2021 09:50:15 +0800 Subject: Re: [PATCH v2 4/6] nvme-rdma: avoid IO error and repeated request completion To: Christoph Hellwig References: <20210107033149.15701-1-lengchao@huawei.com> <20210107033149.15701-5-lengchao@huawei.com> <07e41b4f-914a-11e8-5638-e2d6408feb3f@grimberg.me> <7b12be41-0fcd-5a22-0e01-8cd4ac9cde5b@huawei.com> <695b6839-5333-c342-2189-d7aaeba797a7@huawei.com> <4ff22d33-12fa-1f70-3606-54821f314c45@grimberg.me> <0b5c8e31-8dc2-994a-1710-1b1be07549c9@huawei.com> <20210118174913.GA8700@lst.de> From: Chao Leng Message-ID: <2483994e-1bc2-8d80-468e-94b898b7dc09@huawei.com> Date: Tue, 19 Jan 2021 09:50:15 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20210118174913.GA8700@lst.de> Content-Language: en-US X-Originating-IP: [10.169.42.93] X-ClientProxiedBy: dggeme702-chm.china.huawei.com (10.1.199.98) To dggema772-chm.china.huawei.com (10.1.198.214) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210118_205028_370389_E3E5CE35 X-CRM114-Status: GOOD ( 10.95 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: axboe@kernel.dk, linux-block@vger.kernel.org, Sagi Grimberg , linux-nvme@lists.infradead.org, axboe@fb.com, kbusch@kernel.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On 2021/1/19 1:49, Christoph Hellwig wrote: > On Mon, Jan 18, 2021 at 11:22:16AM +0800, Chao Leng wrote: >>> Well, certainly this one-shot always return 0 and complete the command >>> with HOST_PATH error is not a good approach IMO >> So what's the better option? Just complete the request with host path >> error for non-ENOMEM and EAGAIN returned by the HBA driver? > > what HBA driver? mlx4 and mlx5. > . > _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme