From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Keith Busch <kbusch@meta.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Cc: "hch@lst.de" <hch@lst.de>, "sagi@grimberg.me" <sagi@grimberg.me>,
Keith Busch <kbusch@kernel.org>, Len Brown <lenb@kernel.org>
Subject: Re: [PATCH] nvme: change shutdown timeout setting message
Date: Fri, 8 Mar 2024 00:11:05 +0000 [thread overview]
Message-ID: <262fd7fd-77b2-4a44-9364-ec5b67ae709b@nvidia.com> (raw)
In-Reply-To: <20240307165933.3718589-1-kbusch@meta.com>
On 3/7/24 08:59, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
>
> User visible messages containing the word "timeout" can be alarming.
> This one nvme is just reporting a potentially informative device
> configuration, and everything is working as designed. Change the text to
> report the less concerning "D3 entry latency", which is where this value
> comes from anyway.
>
> Reported-by: Len Brown <lenb@kernel.org>
> Signed-off-by: Keith Busch <kbusch@kernel.org>
> ---
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
next prev parent reply other threads:[~2024-03-08 0:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 16:59 [PATCH] nvme: change shutdown timeout setting message Keith Busch
2024-03-08 0:11 ` Chaitanya Kulkarni [this message]
2024-03-08 10:09 ` Sagi Grimberg
2024-03-08 14:45 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=262fd7fd-77b2-4a44-9364-ec5b67ae709b@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=lenb@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox