From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BAE7AC4332F for ; Tue, 22 Nov 2022 16:05:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ImVe+g+b+10JJjRyFbVg3VQDLgN59Ue/Abv7vaFmseQ=; b=js00OPIMI/QoppbmS8dkoTlUk8 ZBSANzfye0AtsM7G7KPReNR7shiUIxL1CuTR1r7qRk06xC1Rt3VtmK0fVKLOkdDY9M/dZIOg+TFvl TJzEBVkUwIi6o5k2dg1nUbJJuxJYvxoKUjlSPgXSVJJiKsjQ899D/hDbzHKn199PAwR1/OXFIN3kj 41IeZC6G+pKtKOSv7V5jlWtgbACQNtC1WOhjM/PEKCMv5w8zHfWyy6fbPfYfCfqnPgqMOiVFmuyXh Q892xG05dxqbn6gZiBf3iixKoJhOKwxAPJLEwlDt71PcunkBFz5efpih+5SSfJ+gaocAaqVUhqFz6 Xr6FkDew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxVm7-00Aa9o-S7; Tue, 22 Nov 2022 16:05:31 +0000 Received: from mail-io1-xd34.google.com ([2607:f8b0:4864:20::d34]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxEZk-000XJ4-4k for linux-nvme@lists.infradead.org; Mon, 21 Nov 2022 21:43:37 +0000 Received: by mail-io1-xd34.google.com with SMTP id p141so9623238iod.6 for ; Mon, 21 Nov 2022 13:43:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ImVe+g+b+10JJjRyFbVg3VQDLgN59Ue/Abv7vaFmseQ=; b=OHO4FjaPJmimqdrzS/OkstIvhocxCz1emkoHfOdBnFW624ABdZXIGpUr2qg1Kuoid7 jQ3zRS/xznKzGtwvpkBw8YcBHanbAjUGKtSMJ92a5WUJdkI77H4tBot4cVhu32vyccdd iMTMhCXmKhazzg9UmrMMNr5aOJxLl31QLMnEw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ImVe+g+b+10JJjRyFbVg3VQDLgN59Ue/Abv7vaFmseQ=; b=zqYvgnu9YslPxsPzvdEfyN/VSGn8Gk8Y7wQ/T9lLvcMLTNt55iUqlVPB7NmJyjkjfJ I7P6TtHb8PwTf1OlHkQ1fpG1gWacSEX5wfaBo7caMFzIRsD3aVRb7ikXSQ1TeWaPbrfB x4E/pD8AzlMpEOqEj/sD4R3HjDa3Zt2sq2ZYS04tVfgxDgRJElFT2BEELxXXuzY193hd GiwJHzPB9linRdHbrHFGxNh1GAwe+M3OUPv5lx22pVCpjrz4ynCh+F/BxWQ9S0dlmQbR f/K0dKbDSUEnMiEDM7VdWLZJHomlbc3sJ8rZMeoOi6k5GRrv35W3JsSUsEj19QZqqcCH Rdtg== X-Gm-Message-State: ANoB5plyayA4l04jffruyU/5o4i9SWKQKF5IUtihyXAO049BTydbSZQI s179jA3uCuiErD9q5EZajBLYcQ== X-Google-Smtp-Source: AA0mqf7f7poc1w7ewSMxS1++ciq574fA83Q7zTNUSYFoHm3cWPyzQwbrRSPhTjg/tqVe+6wU++ijsA== X-Received: by 2002:a5d:9c0d:0:b0:6de:e346:27d4 with SMTP id 13-20020a5d9c0d000000b006dee34627d4mr639526ioe.138.1669067012402; Mon, 21 Nov 2022 13:43:32 -0800 (PST) Received: from [192.168.1.128] ([38.15.45.1]) by smtp.gmail.com with ESMTPSA id p5-20020a92c105000000b00302a7165d9bsm3672008ile.53.2022.11.21.13.43.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Nov 2022 13:43:31 -0800 (PST) Message-ID: <26d98c8f-372b-b9c8-c29f-096cddaff149@linuxfoundation.org> Date: Mon, 21 Nov 2022 14:43:29 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v1 2/3] Treewide: Stop corrupting socket's task_frag Content-Language: en-US To: Benjamin Coddington , David Howells Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Philipp Reisner , Lars Ellenberg , =?UTF-8?Q?Christoph_B=c3=b6hmwalder?= , Jens Axboe , Josef Bacik , Keith Busch , Christoph Hellwig , Sagi Grimberg , Lee Duncan , Chris Leech , Mike Christie , "James E.J. Bottomley" , "Martin K. Petersen" , Valentina Manea , Shuah Khan , Greg Kroah-Hartman , Marc Dionne , Steve French , Christine Caulfield , David Teigland , Mark Fasheh , Joel Becker , Joseph Qi , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Ilya Dryomov , Xiubo Li , Trond Myklebust , Anna Schumaker , Chuck Lever , Jeff Layton , drbd-dev@lists.linbit.com, linux-block@vger.kernel.org, nbd@other.debian.org, linux-nvme@lists.infradead.org, open-iscsi@googlegroups.com, linux-scsi@vger.kernel.org, linux-usb@vger.kernel.org, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com, v9fs-developer@lists.sourceforge.net, ceph-devel@vger.kernel.org, linux-nfs@vger.kernel.org, Shuah Khan References: <382872.1669039019@warthog.procyon.org.uk> <51B5418D-34FB-4E87-B87A-6C3FCDF8B21C@redhat.com> <4585e331-03ad-959f-e715-29af15f63712@linuxfoundation.org> From: Shuah Khan In-Reply-To: <4585e331-03ad-959f-e715-29af15f63712@linuxfoundation.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221121_134336_190994_D45B79B8 X-CRM114-Status: GOOD ( 14.27 ) X-Mailman-Approved-At: Tue, 22 Nov 2022 08:05:24 -0800 X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On 11/21/22 14:40, Shuah Khan wrote: > On 11/21/22 07:34, Benjamin Coddington wrote: >> On 21 Nov 2022, at 8:56, David Howells wrote: >> >>> Benjamin Coddington wrote: >>> >>>> Since moving to memalloc_nofs_save/restore, SUNRPC has stopped setting the >>>> GFP_NOIO flag on sk_allocation which the networking system uses to decide >>>> when it is safe to use current->task_frag. >>> >>> Um, what's task_frag? >> >> Its a per-task page_frag used to coalesce small writes for networking -- see: >> >> 5640f7685831 net: use a per task frag allocator >> >> Ben >> >> > > I am not seeing this in the mainline. Where can find this commit? > Okay. I see this commit in the mainline. However, I don't see the sk_use_task_frag in mainline. thanks, -- Shuah