From: Baolin Wang <baolin.wang@linux.alibaba.com>
To: kbusch@kernel.org, axboe@fb.com, hch@lst.de, sagi@grimberg.me
Cc: baolin.wang7@gmail.com, linux-kernel@vger.kernel.org,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme: Simplify the nvme_req_qid()
Date: Mon, 2 Nov 2020 19:44:21 +0800 [thread overview]
Message-ID: <2735ac5c-3d7a-0829-368a-2066e75fe635@linux.alibaba.com> (raw)
In-Reply-To: <3ddb02eee7765d63328da3e1499a26da5cd20f1b.1603785673.git.baolin.wang@linux.alibaba.com>
Hi,
> Use the request's '->mq_hctx->queue_num' directly to simplify the
> nvme_req_qid() function.
>
> Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
Gentle ping?
> ---
> drivers/nvme/host/nvme.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/host/nvme.h b/drivers/nvme/host/nvme.h
> index cc11113..0b62b62 100644
> --- a/drivers/nvme/host/nvme.h
> +++ b/drivers/nvme/host/nvme.h
> @@ -178,7 +178,8 @@ static inline u16 nvme_req_qid(struct request *req)
> {
> if (!req->q->queuedata)
> return 0;
> - return blk_mq_unique_tag_to_hwq(blk_mq_unique_tag(req)) + 1;
> +
> + return req->mq_hctx->queue_num + 1;
> }
>
> /* The below value is the specific amount of delay needed before checking
>
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-11-02 11:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 8:15 [PATCH] nvme: Simplify the nvme_req_qid() Baolin Wang
2020-11-02 11:44 ` Baolin Wang [this message]
2020-11-02 18:02 ` Christoph Hellwig
2020-11-06 13:56 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2735ac5c-3d7a-0829-368a-2066e75fe635@linux.alibaba.com \
--to=baolin.wang@linux.alibaba.com \
--cc=axboe@fb.com \
--cc=baolin.wang7@gmail.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox