From: Jens Axboe <axboe@kernel.dk>
To: Keith Busch <kbusch@meta.com>, linux-nvme@lists.infradead.org
Cc: hch@lst.de, sagi@grimberg.me, Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH] nvme-core: check for too small lba shift
Date: Tue, 28 Nov 2023 12:10:29 -0700 [thread overview]
Message-ID: <276e4ae6-a591-43d1-a80e-e07dc72b33d4@kernel.dk> (raw)
In-Reply-To: <20231128173955.339941-1-kbusch@meta.com>
On 11/28/23 10:39 AM, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
>
> The block layer doesn't support logical block sizes smaller than 512
> bytes. The nvme spec doesn't support that small either, but the driver
> isn't checking to make sure the device responded with usable data.
> Failing to catch this will result in a kernel bug, either from a
> division by zero when stacking, or a zero length bio.
Reviewed-by: Jens Axboe <axboe@kernel.dk>
--
Jens Axboe
next prev parent reply other threads:[~2023-11-28 19:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-28 17:39 [PATCH] nvme-core: check for too small lba shift Keith Busch
2023-11-28 19:10 ` Jens Axboe [this message]
2023-11-28 20:44 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=276e4ae6-a591-43d1-a80e-e07dc72b33d4@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox