From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BFB27C433F5 for ; Wed, 18 May 2022 22:41:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6CjLHJv2KA3UYpol8fjDDq5hkiBotVVzrhywge1qyNU=; b=gDJVZH3OXGK0yR4CE55Cr2E/t2 +oqvD8Ei9JnPws/EprVz+WNWV8knLyXYSPoPb3e1pryNB/dneGRDOLy8cKwKn0EJFOYpNK4XHm19w ALWyr1R5E3Km5ppCMKozmjLeVPf6EHxygaPTR21H4GQHZpnSWCrD7j6HS1pntX94wIZRNTzsP/tyv qU4HLCPEQqyKXFdHQPWKmgbb17JSwQKqCno/PEaW4FGyJOi49KJUqWDHBSd56GRGDmOawyWDA9ZtC sFgdUhZoiqJwnPrch4wVD8HgUe1dcHXeModBcHVQib/R5p9VUkVC5f1h+q64hsDJIL4WUdujACMuq tWwp9llQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nrSLm-0049Yl-HS; Wed, 18 May 2022 22:41:02 +0000 Received: from mail-pj1-x102d.google.com ([2607:f8b0:4864:20::102d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nrSLj-0049Xs-OE for linux-nvme@lists.infradead.org; Wed, 18 May 2022 22:41:01 +0000 Received: by mail-pj1-x102d.google.com with SMTP id nr2-20020a17090b240200b001df2b1bfc40so6978389pjb.5 for ; Wed, 18 May 2022 15:40:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=6CjLHJv2KA3UYpol8fjDDq5hkiBotVVzrhywge1qyNU=; b=wrJMFTIQ7Yp9Uql3VLw0P3eZsDs+b1JV9KcU/0cWmfEKtzb2nHz9qQOWcknqiv3wB6 Qe/tgV7Wd1ZHgM0PLCX4x70ixWK4nzzI8BoHFoJI7M5IVH+dxrvEfNoN7lwgKCD2f3s1 SssvyCbsFzUf3QgcSJFKnLglCQxAspEBBcIEcsJDQCshhG6gmosFUSSFrwSOE+2aeTrU 2lNPrBXDbYcs5PXq5jKYOuXIF1vCRi6YBouhmgTOE0bqz//uobUJex8BrlGWvPJWaR5i sNQ5I6zJ8fIjyybnFPYO1nhn+R5wcXeiyVTVwrufjzrTk7Hnrt7K/zVniZVpM1tdT3X9 TXQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=6CjLHJv2KA3UYpol8fjDDq5hkiBotVVzrhywge1qyNU=; b=C1DW8/bZUmcGn/3jN7zi4Gvm1wsOCMWKXyeeI57ivxhX+WQd/LKMNSbCINOmWxOgaf OIN4BCA6oQdNcUGcydiSilHBcsFRdVq67AkqurYISGdCQxF25GeK3975dKTxgM4KIpQZ R3PxweqXrYGOlSrjGNWuSYtozII0mhko55DtIcuM25y/ArbadzFovWwUWo5c2NVtC3ka IZFm1nDAGmVeRlY3yK4eywMCd+tRrfsdEZ4Cu+MEa4VFS3Uxj32N4Z7TAkcesQbB30/K lotLdpwkj7iSrRyj/loRaIFzqcGhP2eeAc2iIV8r1QGoBr5aB23ItsxgJAke8R4Xc7iC t0vA== X-Gm-Message-State: AOAM532kE8bNVZpC8zJMBriNkX+bdTop8GN0LOFLDMY7Eud3v4uDFdEl suawK1AOZTj5xJ6LGyVj1DMwPA== X-Google-Smtp-Source: ABdhPJzs5D3xiswFdU/ktExKQiuNvoDQe4ombx0sc+ixFqOYLAZByoojFMvCFdJR/wrJj7TUPZJQmg== X-Received: by 2002:a17:90a:940d:b0:1df:359b:2f9e with SMTP id r13-20020a17090a940d00b001df359b2f9emr2261914pjo.235.1652913656802; Wed, 18 May 2022 15:40:56 -0700 (PDT) Received: from [192.168.1.100] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id a1-20020a1709027e4100b0015e8d4eb277sm2151000pln.193.2022.05.18.15.40.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 May 2022 15:40:56 -0700 (PDT) Message-ID: <28682d9a-ac58-ea19-6d51-73fbd87bfb5e@kernel.dk> Date: Wed, 18 May 2022 16:40:55 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: cleanup blk_execute_rq* Content-Language: en-US To: Christoph Hellwig Cc: Ming Lei , linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org References: <20220517064901.3059255-1-hch@lst.de> From: Jens Axboe In-Reply-To: <20220517064901.3059255-1-hch@lst.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220518_154059_831409_168B22FD X-CRM114-Status: GOOD ( 11.21 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On 5/17/22 12:48 AM, Christoph Hellwig wrote: > Hi Jens, > > this series cleans up the blk_execute_rq* helpers. It simplifies the > plugging mess a bit, fixes the sparse __bitwise warnings and simplifies > the blk_execute_rq_nowait API a bit. Looks good to me, but let's do this series post flushing out the initial bits. It ends up depending on the passthrough changes, yet also conflicts with the nvme changes on the driver side. -- Jens Axboe