From: jsmart2021@gmail.com (James Smart)
Subject: [PATCH] nvme_fc: add message on final controller removal
Date: Wed, 20 Sep 2017 14:47:59 -0700 [thread overview]
Message-ID: <28899ddd-7fbb-89bb-97eb-9c54ae6d9cbb@gmail.com> (raw)
In-Reply-To: <20170920213214.GC10442@infradead.org>
On 9/20/2017 2:32 PM, Christoph Hellwig wrote:
> On Tue, Sep 19, 2017@02:02:10PM -0700, James Smart wrote:
>> Given disparity between class level delete and transport delete,
>> add an info message when the transport controller object deletes.
>
> Hmm. Why do we need this in the FC code?
>
It's a debug aid. I'm finding all the transitions spit out messages
saying controller is deleting, which makes the admin think it's deleted.
But what really happened was the delete calls were made to the core
routines, but those routines are getting hung up in ns teardown. So
admins are reporting things as "deleted" when they really aren't yet.
This message just book-ends the initial deleting messages.
it could certainly go in the core nvme_free_ctrl() call before it calls
the transport free routine.
-- james
prev parent reply other threads:[~2017-09-20 21:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-19 21:02 [PATCH] nvme_fc: add message on final controller removal James Smart
2017-09-20 21:32 ` Christoph Hellwig
2017-09-20 21:47 ` James Smart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28899ddd-7fbb-89bb-97eb-9c54ae6d9cbb@gmail.com \
--to=jsmart2021@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox