From: Hannes Reinecke <hare@suse.de>
To: alistair23@gmail.com, kbusch@kernel.org, axboe@kernel.dk,
hch@lst.de, sagi@grimberg.me, kch@nvidia.com,
linux-nvme@lists.infradead.org
Cc: linux-kernel@vger.kernel.org,
Alistair Francis <alistair.francis@wdc.com>
Subject: Re: [PATCH v2 2/4] nvmet-tcp: Don't free SQ on authentication success
Date: Wed, 12 Nov 2025 08:07:18 +0100 [thread overview]
Message-ID: <2a0c50cf-86b3-45bd-aa8d-c462aae5b900@suse.de> (raw)
In-Reply-To: <20251111234519.3467440-3-alistair.francis@wdc.com>
On 11/12/25 00:45, alistair23@gmail.com wrote:
> From: Alistair Francis <alistair.francis@wdc.com>
>
> Curently after the host sends a REPLACETLSPSK we free the TLS keys as
> part of calling nvmet_auth_sq_free() on success. This means when the
> host sends a follow up REPLACETLSPSK we return CONCAT_MISMATCH as the
> check for !nvmet_queue_tls_keyid(req->sq) fails.
>
> This patch ensures we don't free the TLS key on success as we might need
> it again in the future.
>
> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> ---
> v2:
> - Don't call nvmet_auth_sq_free() in nvmet_execute_auth_send() either
>
> drivers/nvme/target/fabrics-cmd-auth.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich
next prev parent reply other threads:[~2025-11-12 7:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-11 23:45 [PATCH v2 0/4] Support PSK reauthentication (REPLACETLSPSK) alistair23
2025-11-11 23:45 ` [PATCH v2 1/4] nvmet-tcp: Don't error if TLS is enabed on a reset alistair23
2025-11-12 1:13 ` Wilfred Mallawa
2025-11-12 6:54 ` Christoph Hellwig
2025-11-12 7:05 ` Hannes Reinecke
2025-11-11 23:45 ` [PATCH v2 2/4] nvmet-tcp: Don't free SQ on authentication success alistair23
2025-11-12 6:54 ` Christoph Hellwig
2025-11-12 7:07 ` Hannes Reinecke [this message]
2025-11-11 23:45 ` [PATCH v2 3/4] nvme: Expose the tls_configured sysfs for secure concat connections alistair23
2025-11-12 6:54 ` Christoph Hellwig
2025-11-12 7:08 ` Hannes Reinecke
2025-11-13 2:08 ` Alistair Francis
2025-11-13 7:21 ` Hannes Reinecke
2025-11-13 12:22 ` Alistair Francis
2025-11-13 12:45 ` Hannes Reinecke
2025-11-14 3:47 ` Alistair Francis
2025-11-11 23:45 ` [PATCH v2 4/4] nvme: Allow reauth from sysfs alistair23
2025-11-12 0:45 ` Chaitanya Kulkarni
2025-11-12 6:56 ` Christoph Hellwig
2025-11-13 12:23 ` Alistair Francis
2025-11-12 7:12 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a0c50cf-86b3-45bd-aa8d-c462aae5b900@suse.de \
--to=hare@suse.de \
--cc=alistair.francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox