Re: [PATCH 1/4] blk-mq: move the call to blk_put_queue out of blk_mq_destroy_queue

Jens Axboe
2022-10-25T14:24:51Z

> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index 059737c1a2c19..07381673170b9 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -4847,6 +4847,7 @@ int nvme_alloc_admin_tag_set(struct nvme_ctrl *ctrl, struct blk_mq_tag_set *set,
>
> out_cleanup_admin_q:
> blk_mq_destroy_queue(ctrl->fabrics_q);
> + blk_put_queue(ctrl->fabrics_q);
> out_free_tagset:
> blk_mq_free_tag_set(ctrl->admin_tagset);
> return ret;
This is wrong and doesn't apply because it got fixed upstream:

commit 4739824e2d7878dcea88397a6758e31e3c5c124e
Author: Dan Carpenter <error27@gmail.com>
Date: Sat Oct 15 11:25:56 2022 +0300

nvme: fix error pointer dereference in error handling

Can you respin this series so we can get it applied?

--
Jens Axboe