Re: don't drop the queue reference in blk_mq_destroy_queue

Jens Axboe
2022-10-25T14:27:37Z

On Tue, 18 Oct 2022 15:57:16 +0200, Christoph Hellwig wrote:
> currently blk_mq_destroy_queue not only shuts down the queue, but also
> drops a queue references, which leads to the NVMe PCIe/Apple drivers and
> scsi grabbing an extra references. Fix this to help with unifying more
> code between the various NVMe drivers (and to make the code a little saner
> even on it's own).
>
> Diffstat:
> block/blk-mq.c | 4 +---
> block/bsg-lib.c | 2 ++
> drivers/nvme/host/apple.c | 8 --------
> drivers/nvme/host/core.c | 10 ++++++++--
> drivers/nvme/host/pci.c | 5 -----
> drivers/scsi/scsi_scan.c | 1 -
> drivers/ufs/core/ufshcd.c | 2 ++
> 7 files changed, 13 insertions(+), 19 deletions(-)
>
> [...]

Applied, thanks!

[1/4] blk-mq: move the call to blk_put_queue out of blk_mq_destroy_queue
commit: 2b3f056f72e56fa07df69b4705e0b46a6c08e77c
[2/4] scsi: remove an extra queue reference
commit: dc917c361422388f0d39d3f0dc2bc5a188c01156
[3/4] nvme-pci: remove an extra queue reference
commit: 7dcebef90d35de13a326f765dd787538880566f9
[4/4] nvme-apple: remove an extra queue reference
commit: 941f7298c70c7668416e7845fa76eb72c07d966b

Best regards,
--
Jens Axboe