From: sagi@grimberg.me (Sagi Grimberg)
Subject: [PATCH v2 3/4] nvme: enable SG gaps support
Date: Thu, 20 Apr 2017 14:27:59 +0300 [thread overview]
Message-ID: <2bd673ee-8455-32b7-1bad-34fa9eebb076@grimberg.me> (raw)
In-Reply-To: <1492098977-5231-4-git-send-email-maxg@mellanox.com>
> if (ctrl->quirks & NVME_QUIRK_STRIPE_SIZE)
> blk_queue_chunk_sectors(q, ctrl->max_hw_sectors);
> - blk_queue_virt_boundary(q, ctrl->page_size - 1);
> +
> + if (!ctrl->sg_gaps_support)
> + blk_queue_virt_boundary(q, ctrl->page_size - 1);
> +
I think it would be better if the ctrl will hold a virt_boundary
provided by the fabric driver? Then we would always
blk_queue_virt_boundary but with capable devices the fabric driver
can set it to 0. This will also allow for dword aligned sgls to
fit in pretty easily.
next prev parent reply other threads:[~2017-04-20 11:27 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-13 15:56 [PATCH v2 0/4] arbitrary sg lists support Max Gurtovoy
2017-04-13 15:56 ` [PATCH v2 1/4] IB/core: Add inline function to get sg mr type Max Gurtovoy
2017-04-20 11:24 ` Sagi Grimberg
2017-04-13 15:56 ` [PATCH v2 2/4] IB/iser: Use ib_get_sg_mr_type() helper Max Gurtovoy
2017-04-13 15:56 ` [PATCH v2 3/4] nvme: enable SG gaps support Max Gurtovoy
2017-04-20 11:27 ` Sagi Grimberg [this message]
2017-04-21 6:44 ` Christoph Hellwig
2017-04-23 7:20 ` Sagi Grimberg
2017-04-23 8:45 ` Christoph Hellwig
2017-04-23 9:45 ` Sagi Grimberg
2017-04-23 13:23 ` Max Gurtovoy
2017-04-24 7:02 ` Christoph Hellwig
2017-04-13 15:56 ` [PATCH v2 4/4] nvme-rdma: add support for arbitrary sg lists mapping Max Gurtovoy
2017-04-13 16:31 ` [PATCH v2 0/4] arbitrary sg lists support Bart Van Assche
2017-04-13 16:46 ` Max Gurtovoy
2017-04-13 16:59 ` Laurence Oberman
2017-04-20 11:30 ` Sagi Grimberg
2017-04-23 10:34 ` Leon Romanovsky
2017-04-23 11:49 ` Sagi Grimberg
2017-04-23 12:12 ` Leon Romanovsky
2017-04-23 12:28 ` Sagi Grimberg
2017-04-23 13:35 ` Max Gurtovoy
2017-04-23 14:35 ` Sagi Grimberg
2017-05-01 18:50 ` Doug Ledford
2017-05-02 16:14 ` Max Gurtovoy
2017-05-02 16:39 ` Laurence Oberman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2bd673ee-8455-32b7-1bad-34fa9eebb076@grimberg.me \
--to=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).