Re: [PATCH 09/10] nvmet: introduce new max queue size configuration entry

[Guixin Liu <kanie@linux.alibaba.com>]

lol, I have made this configurable too,

Reviewed-by: Guixin Liu <kanie@linux.alibaba.com>

在 2023/12/31 08:52, Max Gurtovoy 写道:
> Using this port configuration, one will be able to set the maximal queue
> size to be used for any controller that will be associated to the
> configured port.
>
> The default value stayed 1024 but each transport will be able to set the
> its own values before enabling the port.
>
> Reviewed-by: Israel Rukshin <israelr@nvidia.com>
> Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
> ---
>   drivers/nvme/target/configfs.c | 28 ++++++++++++++++++++++++++++
>   drivers/nvme/target/core.c     | 16 ++++++++++++++--
>   drivers/nvme/target/nvmet.h    |  1 +
>   3 files changed, 43 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/nvme/target/configfs.c b/drivers/nvme/target/configfs.c
> index bd514d4c4a5b..f8df2ef715ba 100644
> --- a/drivers/nvme/target/configfs.c
> +++ b/drivers/nvme/target/configfs.c
> @@ -272,6 +272,32 @@ static ssize_t nvmet_param_inline_data_size_store(struct config_item *item,
>   
>   CONFIGFS_ATTR(nvmet_, param_inline_data_size);
>   
> +static ssize_t nvmet_param_max_queue_size_show(struct config_item *item,
> +		char *page)
> +{
> +	struct nvmet_port *port = to_nvmet_port(item);
> +
> +	return snprintf(page, PAGE_SIZE, "%d\n", port->max_queue_size);
> +}
> +
> +static ssize_t nvmet_param_max_queue_size_store(struct config_item *item,
> +		const char *page, size_t count)
> +{
> +	struct nvmet_port *port = to_nvmet_port(item);
> +	int ret;
> +
> +	if (nvmet_is_port_enabled(port, __func__))
> +		return -EACCES;
> +	ret = kstrtoint(page, 0, &port->max_queue_size);
> +	if (ret) {
> +		pr_err("Invalid value '%s' for max_queue_size\n", page);
> +		return -EINVAL;
> +	}
> +	return count;
> +}
> +
> +CONFIGFS_ATTR(nvmet_, param_max_queue_size);
> +
>   #ifdef CONFIG_BLK_DEV_INTEGRITY
>   static ssize_t nvmet_param_pi_enable_show(struct config_item *item,
>   		char *page)
> @@ -1856,6 +1882,7 @@ static struct configfs_attribute *nvmet_port_attrs[] = {
>   	&nvmet_attr_addr_trtype,
>   	&nvmet_attr_addr_tsas,
>   	&nvmet_attr_param_inline_data_size,
> +	&nvmet_attr_param_max_queue_size,
>   #ifdef CONFIG_BLK_DEV_INTEGRITY
>   	&nvmet_attr_param_pi_enable,
>   #endif
> @@ -1914,6 +1941,7 @@ static struct config_group *nvmet_ports_make(struct config_group *group,
>   	INIT_LIST_HEAD(&port->subsystems);
>   	INIT_LIST_HEAD(&port->referrals);
>   	port->inline_data_size = -1;	/* < 0 == let the transport choose */
> +	port->max_queue_size = -1;	/* < 0 == let the transport choose */
>   
>   	port->disc_addr.portid = cpu_to_le16(portid);
>   	port->disc_addr.adrfam = NVMF_ADDR_FAMILY_MAX;
> diff --git a/drivers/nvme/target/core.c b/drivers/nvme/target/core.c
> index f08997f58101..f7d82da4c1bc 100644
> --- a/drivers/nvme/target/core.c
> +++ b/drivers/nvme/target/core.c
> @@ -358,6 +358,17 @@ int nvmet_enable_port(struct nvmet_port *port)
>   	if (port->inline_data_size < 0)
>   		port->inline_data_size = 0;
>   
> +	/*
> +	 * If the transport didn't set the max_queue_size properly, then clamp
> +	 * it to the global fabrics limits.
> +	 */
> +	if (port->max_queue_size < 0)
> +		port->max_queue_size = NVMF_MAX_QUEUE_SIZE;
> +	else
> +		port->max_queue_size = clamp_t(int, port->max_queue_size,
> +					       NVMF_MIN_QUEUE_SIZE,
> +					       NVMF_MAX_QUEUE_SIZE);
> +
>   	port->enabled = true;
>   	port->tr_ops = ops;
>   	return 0;
> @@ -1223,9 +1234,10 @@ static void nvmet_init_cap(struct nvmet_ctrl *ctrl)
>   	ctrl->cap |= (15ULL << 24);
>   	/* maximum queue entries supported: */
>   	if (ctrl->ops->get_max_queue_size)
> -		ctrl->cap |= ctrl->ops->get_max_queue_size(ctrl) - 1;
> +		ctrl->cap |= min_t(u16 , ctrl->ops->get_max_queue_size(ctrl),
> +				   ctrl->port->max_queue_size) - 1;
>   	else
> -		ctrl->cap |= NVMF_MAX_QUEUE_SIZE - 1;
> +		ctrl->cap |= ctrl->port->max_queue_size - 1;
>   
>   	if (nvmet_is_passthru_subsys(ctrl->subsys))
>   		nvmet_passthrough_override_cap(ctrl);
> diff --git a/drivers/nvme/target/nvmet.h b/drivers/nvme/target/nvmet.h
> index a76f816edf1d..ab6459441376 100644
> --- a/drivers/nvme/target/nvmet.h
> +++ b/drivers/nvme/target/nvmet.h
> @@ -163,6 +163,7 @@ struct nvmet_port {
>   	void				*priv;
>   	bool				enabled;
>   	int				inline_data_size;
> +	int				max_queue_size;
>   	const struct nvmet_fabrics_ops	*tr_ops;
>   	bool				pi_enable;
>   };