From: Hannes Reinecke <hare@suse.de>
To: Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>
Cc: Keith Busch <keith.busch@wdc.com>,
Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme: retrigger ANA log update if group descriptor isn't found
Date: Mon, 7 Dec 2020 16:51:11 +0100 [thread overview]
Message-ID: <2ecc3aa8-7b2a-77fa-642f-05cac1a602da@suse.de> (raw)
In-Reply-To: <20201207153443.GA6236@lst.de>
On 12/7/20 4:34 PM, Christoph Hellwig wrote:
> On Mon, Dec 07, 2020 at 07:31:21AM -0800, Keith Busch wrote:
>> On Sat, Dec 05, 2020 at 04:29:01PM +0100, Hannes Reinecke wrote:
>>> If ANA is enabled but no ANA group descriptor is found when creating
>>> a new namespace the ANA log is most likely out of date, so trigger
>>> a re-read. The namespace will be tagged with the NS_ANA_PENDING flag
>>> to exclude it from path selection until the ANA log has been re-read.
>>>
>>> Reported-by: Martin George <marting@netapp.com>
>>> Signed-off-by: Hannes Reinecke <hare@suse.de>
>>
>> This looks good to me.
>>
>> Reviewed-by: Keith Busch <kbusch@kernel.org>
>
> But as I just outlined it just papers over buggy controllers. I really
> don't think we should just silently do that.
>
What would be the downside of taking this patch?
Personally, I'd rather be lenient and allow to interoperate...
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-12-07 15:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-05 15:29 [PATCH] nvme: retrigger ANA log update if group descriptor isn't found Hannes Reinecke
2020-12-07 15:31 ` Keith Busch
2020-12-07 15:34 ` Christoph Hellwig
2020-12-07 15:46 ` Keith Busch
2020-12-08 14:03 ` Christoph Hellwig
2020-12-08 19:17 ` Keith Busch
2020-12-09 7:35 ` Christoph Hellwig
2020-12-07 15:51 ` Hannes Reinecke [this message]
2021-01-14 3:13 ` Sagi Grimberg
2021-03-25 10:55 ` George, Martin
2021-03-25 21:54 ` Keith Busch
2021-03-25 22:20 ` Sagi Grimberg
2021-04-02 16:49 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ecc3aa8-7b2a-77fa-642f-05cac1a602da@suse.de \
--to=hare@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=keith.busch@wdc.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox