From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Keith Busch <kbusch@kernel.org>
Cc: "sagi@grimberg.me" <sagi@grimberg.me>, "hch@lst.de" <hch@lst.de>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Subject: Re: [PATCH] nvme: explicitly set non-error for directives
Date: Tue, 15 Feb 2022 17:04:19 +0000 [thread overview]
Message-ID: <312922c0-e780-dc81-ae6a-ecdcc24378f4@nvidia.com> (raw)
In-Reply-To: <20220215150308.1902842-1-kbusch@kernel.org>
On 2/15/22 07:03, Keith Busch wrote:
> Stream directives is an optional feature. It is not an error if a
> controller doesn't support as many as the kernel can optionally use.
> Explicitly set the non-error return value on this condition with a
> comment explaining why.
>
> Note, the return value was already 0 in this condition, so the setting
> is redundant. This patch should just silence bots that falsely believe
> the condition contains an error omission.
>
> Cc: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> Signed-off-by: Keith Busch <kbusch@kernel.org>
> ---
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
next prev parent reply other threads:[~2022-02-15 17:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-15 15:03 [PATCH] nvme: explicitly set non-error for directives Keith Busch
2022-02-15 17:04 ` Chaitanya Kulkarni [this message]
2022-02-16 8:05 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=312922c0-e780-dc81-ae6a-ecdcc24378f4@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=hch@lst.de \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox