From: Hannes Reinecke <hare@suse.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
linux-nvme@lists.infradead.org, Sagi Grimberg <sagi@grimberg.me>
Subject: Re: [PATCH] nvme: always treat DNR status as no-retryable
Date: Tue, 26 Nov 2019 17:34:21 +0100 [thread overview]
Message-ID: <3186d79f-910a-18f6-dcae-080b370bcab3@suse.de> (raw)
In-Reply-To: <20191126161532.GB2906@redsun51.ssa.fujisawa.hgst.com>
On 11/26/19 5:15 PM, Keith Busch wrote:
> On Tue, Nov 26, 2019 at 02:37:49PM +0100, Hannes Reinecke wrote:
>> If the DNR bit is set in the command status we should not retry
>> the command, irrespective of what the actual status is.
>> So map it directly to BLK_STS_TARGET to inform upper layers to
>> not retry the command, not even on another path.
>
> Why can't a DNR error be path specific, like if I detach a namespace
> from one of the controllers?
>
I've discussed the very same question with Fred Knight, and according to
him the 'DNR' bit is _command_ specific, ie _this particular command_
should not be retried.
Any eventual alternative path should not be considered.
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2019-11-26 16:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-26 13:37 [PATCH] nvme: always treat DNR status as no-retryable Hannes Reinecke
2019-11-26 16:15 ` Keith Busch
2019-11-26 16:34 ` Hannes Reinecke [this message]
2019-11-26 16:39 ` Christoph Hellwig
2019-11-26 16:22 ` Christoph Hellwig
2019-11-26 16:28 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3186d79f-910a-18f6-dcae-080b370bcab3@suse.de \
--to=hare@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox