From: John Garry <john.g.garry@oracle.com>
To: Christoph Hellwig <hch@infradead.org>,
Chaitanya Kulkarni <chaitanyak@nvidia.com>
Cc: "alan.adamson@oracle.com" <alan.adamson@oracle.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: Re: Issue with AWUPF when using multiple controllers in a subsystem
Date: Thu, 10 Apr 2025 10:09:53 +0100 [thread overview]
Message-ID: <34d750b4-88b0-4e4d-8545-3550175529aa@oracle.com> (raw)
In-Reply-To: <Z_Y3V6i7dG5Hr635@infradead.org>
On 09/04/2025 10:01, Christoph Hellwig wrote:
> On Tue, Apr 08, 2025 at 09:08:18PM +0000, Chaitanya Kulkarni wrote:
>>>
>>> I think the awupf belongs in the nvme_ctrl structure.
>>
>> AWUPF is a part of Identify controller data structure so Ideally
>> it should be part of the controller attribute.
>
> It is subsystem scoped really, and controllers should not differ
> in the values as that would break multipath setups.
>
> Unfortunately nvme doesn't have an identify subsystem and generally
> is extremely sloppy about scopes.
>
>
This, combined with no dedicated NVMe command to issue a write
atomically (which could error for out-of-limits size/crossing boundary),
is pretty concerning.
As an aside, I found the scope of the boundary definition to be quite
vague as well.
next prev parent reply other threads:[~2025-04-10 11:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-04 22:42 Issue with AWUPF when using multiple controllers in a subsystem alan.adamson
2025-04-08 21:08 ` Chaitanya Kulkarni
2025-04-09 9:01 ` Christoph Hellwig
2025-04-10 9:09 ` John Garry [this message]
2025-04-10 9:19 ` Christoph Hellwig
2025-04-10 10:11 ` John Garry
2025-04-08 21:08 ` Chaitanya Kulkarni
2025-04-09 9:05 ` Christoph Hellwig
2025-04-10 1:33 ` Chaitanya Kulkarni
2025-04-10 8:32 ` Christoph Hellwig
2025-04-10 9:07 ` Keith Busch
2025-04-10 9:17 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34d750b4-88b0-4e4d-8545-3550175529aa@oracle.com \
--to=john.g.garry@oracle.com \
--cc=alan.adamson@oracle.com \
--cc=chaitanyak@nvidia.com \
--cc=hch@infradead.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox