Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@suse.de>
To: Nilay Shroff <nilay@linux.ibm.com>, linux-nvme@lists.infradead.org
Cc: kbusch@kernel.org, hch@lst.de, axboe@kernel.dk, dwagner@suse.de,
	gjoyce@ibm.com
Subject: Re: [RFC PATCHv2 4/4] nvme-multipath: add debugfs attribute for adaptive I/O policy stat
Date: Mon, 13 Oct 2025 08:33:37 +0200	[thread overview]
Message-ID: <359e3d8f-4db7-4430-8520-4fed9de4f48e@suse.de> (raw)
In-Reply-To: <20251009100608.1699550-5-nilay@linux.ibm.com>

On 10/9/25 12:05, Nilay Shroff wrote:
> This commit introduces a new debugfs attribute, "adaptive_stat", under
> both per-path and head debugfs directories (defined under /sys/kernel/
> debug/block/). This attribute provides visibility into the internal
> state of the adaptive I/O policy to aid in debugging and performance
> analysis.
> 
> For per-path entries, "adaptive_stat" reports the corresponding path
> statistics such as I/O weight, selection count, processed samples, and
> ignored samples.
> 
> For head entries, it reports per-CPU statistics for each reachable path,
> including I/O weight, path score, smoothed (EWMA) latency, selection
> count, processed samples, and ignored samples.
> 
> These additions enhance observability of the adaptive I/O path selection
> behavior and help diagnose imbalance or instability in multipath
> performance.
> 
> Signed-off-by: Nilay Shroff <nilay@linux.ibm.com>
> ---
>   drivers/nvme/host/core.c      |   3 +
>   drivers/nvme/host/debugfs.c   | 117 ++++++++++++++++++++++++++++++++++
>   drivers/nvme/host/multipath.c |   2 +
>   3 files changed, 122 insertions(+)
> 
Reviewed-by: Hannes Reinecke <hare@suse.de>

Might be an idea to have support for queue-depth in here, too.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                  Kernel Storage Architect
hare@suse.de                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich


  reply	other threads:[~2025-10-13  6:33 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-09 10:05 [RFC PATCHv2 0/4] nvme-multipath: introduce adaptive I/O policy Nilay Shroff
2025-10-09 10:05 ` [RFC PATCHv2 1/4] block: expose blk_stat_{enable,disable}_accounting() to drivers Nilay Shroff
2025-10-13  5:54   ` Hannes Reinecke
2025-10-09 10:05 ` [RFC PATCHv2 2/4] nvme-multipath: add support for adaptive I/O policy Nilay Shroff
2025-10-13  6:31   ` Hannes Reinecke
2025-10-14  8:57     ` Nilay Shroff
2025-10-09 10:05 ` [RFC PATCHv2 3/4] nvme: add generic debugfs support Nilay Shroff
2025-10-13  6:32   ` Hannes Reinecke
2025-10-09 10:05 ` [RFC PATCHv2 4/4] nvme-multipath: add debugfs attribute for adaptive I/O policy stat Nilay Shroff
2025-10-13  6:33   ` Hannes Reinecke [this message]
2025-10-15  6:19     ` Nilay Shroff
2025-10-16  6:14       ` Hannes Reinecke
2025-10-16  8:27         ` Daniel Wagner
2025-10-16 11:04           ` Nilay Shroff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=359e3d8f-4db7-4430-8520-4fed9de4f48e@suse.de \
    --to=hare@suse.de \
    --cc=axboe@kernel.dk \
    --cc=dwagner@suse.de \
    --cc=gjoyce@ibm.com \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=nilay@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox