From: kashyap.desai@broadcom.com (Kashyap Desai)
Subject: [PATCH 13/14] megaraid_sas: NVME passthru command support
Date: Tue, 9 Jan 2018 22:07:28 +0530 [thread overview]
Message-ID: <35aabb7a8b8ffed4040c5ac01c01fb0a@mail.gmail.com> (raw)
In-Reply-To: <20180108100531.GA6967@infradead.org>
Chris -
Overall NVME support behind MR controller is really a SCSI device. On top
of that, for MegaRaid, NVME device can be part of Virtual Disk and those
drive will not be exposed to the driver. User application may like to talk
to hidden NVME devices (part of VDs). This patch will extend the existing
interface for megaraid product in the same way it is currently supported
for other protocols like SMP, SATA pass-through.
Example - Current smartmon is using megaraid.h (MFI headers) to send SATA
pass-through.
https://github.com/mirror/smartmontools/blob/master/megaraid.h
Any open source application is aware of above interface can extend the
similar support for NVME drives. I agree that current nvme-cli type
interface is not going to be supported using this method. In current
patch, driver processing is very limited since most of the work is handled
in application + FW.
NVME behind MR controller is not really NVME device to the operating
system at block layer. Considering this, do you agree or still foresee any
issues ?
Kashyap
-----Original Message-----
From: Christoph Hellwig [mailto:hch@infradead.org]
Sent: Monday, January 8, 2018 3:36 PM
To: Shivasharan S
Cc: linux-scsi at vger.kernel.org; sumit.saxena at broadcom.com;
linux-nvme at lists.infradead.org; kashyap.desai at broadcom.com
Subject: Re: [PATCH 13/14] megaraid_sas: NVME passthru command support
NAK. Please implement the same ioctl interfaces as the nvme driver
instead of inventing your own incomaptible one.
next prev parent reply other threads:[~2018-01-09 16:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-05 13:35 [PATCH 13/14] megaraid_sas: NVME passthru command support Shivasharan S
2018-01-08 10:05 ` Christoph Hellwig
2018-01-09 16:37 ` Kashyap Desai [this message]
2018-01-09 16:45 ` Christoph Hellwig
2018-01-09 20:50 ` Douglas Gilbert
2018-01-09 23:23 ` Keith Busch
2018-01-10 9:32 ` Kashyap Desai
2018-01-10 10:03 ` Kashyap Desai
2018-01-10 16:22 ` Bart Van Assche
2018-01-10 20:06 ` Douglas Gilbert
2018-01-10 22:14 ` Sathya Prakash Veerichetty
2018-01-11 17:46 ` Keith Busch
2018-01-11 18:07 ` Sathya Prakash Veerichetty
2018-01-15 12:16 ` Kashyap Desai
2018-01-16 3:06 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35aabb7a8b8ffed4040c5ac01c01fb0a@mail.gmail.com \
--to=kashyap.desai@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox