From: james.smart@broadcom.com (James Smart)
Subject: [PATCH] nvme-fc: Implement async-connect option
Date: Tue, 5 Dec 2017 11:41:31 -0800 [thread overview]
Message-ID: <363cfdca-be70-ab28-e241-c835d18c588f@broadcom.com> (raw)
In-Reply-To: <1512461082-41520-1-git-send-email-hare@suse.de>
On 12/5/2017 12:04 AM, Hannes Reinecke wrote:
> By opening the control fd with O_NONBLOCK the fabrics module will
> attempt an async connect if implemented.
> This is especially useful when calling 'nvme connect' from an udev
> rule, as there each program should return as fast as possible to
> avoid an udev event processing stall.
>
> Signed-off-by: Hannes Reinecke <hare at suse.com>
>
This seems odd.?? I would have thought any async connect option would
have been isolated in the fabrics.c file and applicable to any transport.
I can understand why this works as fc is well suited for this division
(allocates ctrl 1st, then makes 1st connection in same style as
reconnects). But the other transports aren't structure the same way so
they're going to be a bit more trouble.
-- james
next prev parent reply other threads:[~2017-12-05 19:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-05 8:04 [PATCH] nvme-fc: Implement async-connect option Hannes Reinecke
2017-12-05 19:41 ` James Smart [this message]
2017-12-06 7:11 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=363cfdca-be70-ab28-e241-c835d18c588f@broadcom.com \
--to=james.smart@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox