From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@lst.de>, Hannes Reinecke <hare@suse.de>
Cc: Sagi Grimberg <sagi@grimberg.me>, Keith Busch <kbusch@kernel.org>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme: retry commands if DNR bit is not set
Date: Wed, 1 Feb 2023 07:45:49 -0700 [thread overview]
Message-ID: <3662f452-a027-5626-d1a3-9559d688408a@kernel.dk> (raw)
In-Reply-To: <20230201130920.GA30589@lst.de>
On 2/1/23 6:09 AM, Christoph Hellwig wrote:
> On Wed, Feb 01, 2023 at 12:50:01PM +0100, Hannes Reinecke wrote:
>> Add a 'retry' argument to __nvme_submit_sync_cmd() to instruct
>> the function to not set the FAILFAST_DRIVER bit for the command,
>> causing it to be retried in nvme_decide_disposition() if the DNR
>> bit is not set in the command result.
>> And modify the authentication code to allow for retries.
>
> This is missing the why. And maybe we can find a better interace than
> a magic bool flag.
The bool addition is awful, I think it's about high time to refactor
that part of the interface rather than piling more junk on top. It's
at 8 arguments even without this change...
--
Jens Axboe
next prev parent reply other threads:[~2023-02-01 14:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 11:50 [PATCH] nvme: retry commands if DNR bit is not set Hannes Reinecke
2023-02-01 13:09 ` Christoph Hellwig
2023-02-01 13:55 ` Hannes Reinecke
2023-02-01 14:45 ` Jens Axboe [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-11-02 7:36 Hannes Reinecke
2022-11-02 8:00 ` Chao Leng
2022-11-02 14:19 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3662f452-a027-5626-d1a3-9559d688408a@kernel.dk \
--to=axboe@kernel.dk \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox