Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: James Smart <jsmart2021@gmail.com>
To: Sagi Grimberg <sagi@grimberg.me>, Hannes Reinecke <hare@suse.de>,
	Christoph Hellwig <hch@lst.de>
Cc: Keith Busch <keith.busch@wdc.com>,
	James Smart <james.smart@broadcom.com>,
	linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme/fc: Short-circuit reconnect retries
Date: Fri, 21 May 2021 13:48:24 -0700	[thread overview]
Message-ID: <373a627a-2c14-32c8-935b-6aa60ba22272@gmail.com> (raw)
In-Reply-To: <4348b2a1-0861-0020-e873-0680812c4849@grimberg.me>

On 5/21/2021 1:17 PM, Sagi Grimberg wrote:
> 
>>       if (recon && nvmf_should_reconnect(&ctrl->ctrl)) {
>> @@ -3286,12 +3290,17 @@ nvme_fc_reconnect_or_delete(struct 
>> nvme_fc_ctrl *ctrl, int status)
>>           queue_delayed_work(nvme_wq, &ctrl->connect_work, recon_delay);
>>       } else {
>> -        if (portptr->port_state == FC_OBJSTATE_ONLINE)
>> -            dev_warn(ctrl->ctrl.device,
>> -                "NVME-FC{%d}: Max reconnect attempts (%d) "
>> -                "reached.\n",
>> -                ctrl->cnum, ctrl->ctrl.nr_reconnects);
>> -        else
>> +        if (portptr->port_state == FC_OBJSTATE_ONLINE) {
>> +            if (status > 0 && (status & NVME_SC_DNR))
>> +                dev_warn(ctrl->ctrl.device,
>> +                     "NVME-FC{%d}: reconnect failure\n",
> 
> Maybe worth to print the status here?
> 
> Otherwise looks good,
> Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
> 

Agree with Sagi that the print should have the status.

Reviewed-by:  James Smart <jsmart2021@gmail.com>

-- james


_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  reply	other threads:[~2021-05-21 20:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-21  8:23 [PATCH] nvme/fc: Short-circuit reconnect retries Hannes Reinecke
2021-05-21 17:28 ` Himanshu Madhani
2021-05-21 20:17 ` Sagi Grimberg
2021-05-21 20:48   ` James Smart [this message]
2021-05-22  9:48   ` Hannes Reinecke
2021-05-25  7:24 ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=373a627a-2c14-32c8-935b-6aa60ba22272@gmail.com \
    --to=jsmart2021@gmail.com \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=james.smart@broadcom.com \
    --cc=keith.busch@wdc.com \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox