Re: [PATCH 0/3] nvme-fabrics: add post connect auth code helper

[Chaitanya Kulkarni <chaitanyak@nvidia.com>]

On 4/15/24 20:53, Chaitanya Kulkarni wrote:
> On 2/7/24 22:24, Chaitanya Kulkarni wrote:
>> Hi,
>>
>> Post connect command authentication handling code is repeated into in
>> nvmf_connect_admin_queue() and nvmf_connect_io_queue(). Moreover this
>> code actully belongs to authentication and should not be a part of
>> common code.
>>
>> Add a helper to handle post connect command authentication. Use the
>> same helper in nvmf_connect_[admin|io]_queue(). This also removes
>> authentication specific code from a build where authentication feature
>> is not configured.
>>
>> I've tested the code with and without NVME_AUTH configured with blktests
>> they are passing. Below is a detailed log.
>>
>> -ck
>>
>> Chaitanya Kulkarni (3):
>>     nvme-fabrics: factor out auth code into helper
>>     nvme-fabrics: use post connect auth helper
>>     nvme-auth: unexport negotiate and wait functions
>>
>>    drivers/nvme/host/auth.c    | 38 +++++++++++++++++++++++++---
>>    drivers/nvme/host/fabrics.c | 50 ++-----------------------------------
>>    drivers/nvme/host/nvme.h    | 16 ++++++------
>>    3 files changed, 43 insertions(+), 61 deletions(-)
>>
>>
> Can someone please look into this series ? this remove unnecessary code
> sitting in the fabrics that should be a part of authentication ...
>
> -ck
>
>

gentle ping, can I get some feedback if this is not needed for any reason ?

-ck