From: james.smart@broadcom.com (James Smart)
Subject: [PATCH] nvme_fc: minor fixes on sqsize
Date: Wed, 7 Mar 2018 13:52:58 -0800 [thread overview]
Message-ID: <37e33bac-cb87-beee-2401-aadd0c9afbb4@broadcom.com> (raw)
In-Reply-To: <20180307154640.GF30975@localhost.localdomain>
On 3/7/2018 7:46 AM, Keith Busch wrote:
> On Mon, Mar 05, 2018@08:55:24PM -0800, James Smart wrote:
>> ret = __nvme_fc_create_hw_queue(ctrl, &ctrl->queues[0], 0,
>> - NVME_AQ_BLK_MQ_DEPTH);
>> + NVME_AQ_BLK_MQ_DEPTH + 1);
> A bit of a nit, but I think you'd prefer to use NVME_AQ_DEPTH here
> instead of assuming the +1.
NP.?? I'll address it. I need to rework the patch as I found another
area when we tune for controller limits that isn't right either.
-- james
prev parent reply other threads:[~2018-03-07 21:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-06 4:55 [PATCH] nvme_fc: minor fixes on sqsize James Smart
2018-03-07 15:46 ` Keith Busch
2018-03-07 21:52 ` James Smart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37e33bac-cb87-beee-2401-aadd0c9afbb4@broadcom.com \
--to=james.smart@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox