From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3FE91C369D7 for ; Tue, 22 Apr 2025 10:29:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TzQsfqrqZUC+j2kc+7gJ1TbtLFTAtUUAK08SBEDTU8M=; b=DzXct+7UF26ZhAMNUbolX0fSZt fpT6RkVvwofgrbfaCQMiGQgjl6kq+lLiRlCNtI7M+Ya7oQcaXsBHC2OZvc6AVIoPYuW3ZfpWCtafa 66kEKiaV/mr4ciP8ly1Hxl2zBziChrF7mmMpQAxrIuNAyZKkpkbP8c4aDM0G0pSKrbwnCzpoC46z/ ZINiTtwc+ICbrdPfCeCiDKW1Y6olp/YgklNFUu4LWcTx2h7dDPzYHa4iMORAQcQCALpHiz2sXZPa/ qOyTdQPyImeKQ59HbQcQYe7evS+9tW2Geb5m+qVVsTcgHoXmWikARrUrFxW9cX4fGoVGpt/eliUPN PE1OsQkA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u7AsG-00000006lz7-2b7M; Tue, 22 Apr 2025 10:29:08 +0000 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u7AIy-00000006deY-2ID8 for linux-nvme@lists.infradead.org; Tue, 22 Apr 2025 09:52:41 +0000 Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53M8bY9d007716; Tue, 22 Apr 2025 09:52:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=TzQsfq rqZUC+j2kc+7gJ1TbtLFTAtUUAK08SBEDTU8M=; b=DS/M568RyxabSn16/T03Ew ExFs/0Q/+ZHHGEHyKsrSiweuhbwoEYURUjmIWCcxFkLlbKTPb/1zaee00GjZilTa WKRglZNrujmIen0o1YD14zbZdyV6xxVolTTXRaKC0xfPfZQUMuO5UtQq8Sqz/HGI uc2sZ2JA9IBG2Fsy9Q0b4MMHzi2loWhGR9tIsQhsYEro2iLpaWIn8jWAQBuSj823 jWTVYZ3aBqOZV1hrxvOV//Bz9IdLQR1ZWq9gSH7cyAtVCDn0pWYNwD1XrzDEdEYY oF24SUFgOe/UzBkVs/kMMRbBGE6lsFhvqjbYeQXTF/qy2ZtV8plzMoD7ikMp2r/A == Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4667rq8bgm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 22 Apr 2025 09:52:29 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 53M7R2UF015450; Tue, 22 Apr 2025 09:52:28 GMT Received: from smtprelay03.dal12v.mail.ibm.com ([172.16.1.5]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 464qnkj61b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 22 Apr 2025 09:52:28 +0000 Received: from smtpav04.wdc07v.mail.ibm.com (smtpav04.wdc07v.mail.ibm.com [10.39.53.231]) by smtprelay03.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 53M9qR758782438 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 22 Apr 2025 09:52:27 GMT Received: from smtpav04.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5042E58056; Tue, 22 Apr 2025 09:52:27 +0000 (GMT) Received: from smtpav04.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 48B3958054; Tue, 22 Apr 2025 09:52:23 +0000 (GMT) Received: from [9.43.46.43] (unknown [9.43.46.43]) by smtpav04.wdc07v.mail.ibm.com (Postfix) with ESMTP; Tue, 22 Apr 2025 09:52:22 +0000 (GMT) Message-ID: <3ae885c1-b72b-4c5e-80cf-fe54d66c1fb3@linux.ibm.com> Date: Tue, 22 Apr 2025 15:22:20 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 1/2] nvme-multipath: introduce delayed removal of the multipath head node To: Christoph Hellwig Cc: linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, kbusch@kernel.org, hare@suse.de, sagi@grimberg.me, jmeneghi@redhat.com, axboe@kernel.dk, gjoyce@ibm.com References: <20250321063901.747605-1-nilay@linux.ibm.com> <20250321063901.747605-2-nilay@linux.ibm.com> <20250407144413.GA12216@lst.de> <5db5ab7b-fdf2-4b40-86fc-3ab4ccff9a41@linux.ibm.com> <20250409104326.GA5359@lst.de> <385cbcd5-fcb1-4f98-bdf7-80b16d4f5f8e@linux.ibm.com> <20250422073607.GA31849@lst.de> Content-Language: en-US From: Nilay Shroff In-Reply-To: <20250422073607.GA31849@lst.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: w-uW46tXJDVbfbopZlCixQdN9FPH6Q6A X-Proofpoint-ORIG-GUID: w-uW46tXJDVbfbopZlCixQdN9FPH6Q6A X-Authority-Analysis: v=2.4 cv=D59HKuRj c=1 sm=1 tr=0 ts=680766dd cx=c_pps a=3Bg1Hr4SwmMryq2xdFQyZA==:117 a=3Bg1Hr4SwmMryq2xdFQyZA==:17 a=IkcTkHD0fZMA:10 a=XR8D0OoHHMoA:10 a=Wu5T-vUgRJGWpmTwq_gA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-22_04,2025-04-21_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 lowpriorityscore=0 clxscore=1015 phishscore=0 mlxlogscore=771 mlxscore=0 bulkscore=0 impostorscore=0 adultscore=0 malwarescore=0 priorityscore=1501 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2504220067 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250422_025240_751354_435A9C23 X-CRM114-Status: GOOD ( 15.52 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On 4/22/25 1:06 PM, Christoph Hellwig wrote: > On Fri, Apr 18, 2025 at 04:15:55PM +0530, Nilay Shroff wrote: >> } >> + >> + if (head->delayed_shutdown_sec) >> + return true; >> + > > Please add a comment explaining this check, but otherwise that sounds > fine. Your text below is a good start for that. > yup, this will be added in the next version of the patch. Thanks, --Nilay