From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Cc: "dwagner@suse.de" <dwagner@suse.de>,
Guixin Liu <kanie@linux.alibaba.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH] nvme/{common/nvme, 051, 052}: introduce def_nsid
Date: Wed, 30 Oct 2024 07:38:23 +0000 [thread overview]
Message-ID: <3b41fb79-78b7-4ddb-a7cc-08000fe8df7d@nvidia.com> (raw)
In-Reply-To: <33susvhlxjt2uf3gqldcb2n43pgrvt5m2wj6b27nbgeoxamfkn@az45ko2fsydt>
On 10/30/24 00:31, Shinichiro Kawasaki wrote:
> On Oct 29, 2024 / 11:19, Guixin Liu wrote:
>> Use def_nsid instead of hard code, the default of def_nsid is 1.
> Hi Guixin, thnaks for the patch.
>
> May I know the motivation to introduce def_nsid? Does it aim to improve code
> readability? Or does it aim to allow testing various def_nsid values?
>
I found it useful where we don't have to hard code the values also
it's easier to search for the default namespace id than individually
looking for it when it's require as number of testcases are growing.
Thanks for suggesting fixes on other testcases.
-ck
next prev parent reply other threads:[~2024-10-30 7:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-29 3:19 [PATCH] nvme/{common/nvme, 051, 052}: introduce def_nsid Guixin Liu
2024-10-29 5:03 ` Chaitanya Kulkarni
2024-10-29 8:48 ` Daniel Wagner
2024-10-30 7:31 ` Shinichiro Kawasaki
2024-10-30 7:38 ` Chaitanya Kulkarni [this message]
2024-10-30 9:44 ` Guixin Liu
2024-10-30 12:24 ` Shinichiro Kawasaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b41fb79-78b7-4ddb-a7cc-08000fe8df7d@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=dwagner@suse.de \
--cc=kanie@linux.alibaba.com \
--cc=linux-nvme@lists.infradead.org \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox