From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D72FEC433E0 for ; Thu, 4 Feb 2021 15:28:18 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8DA2E64DE7 for ; Thu, 4 Feb 2021 15:28:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8DA2E64DE7 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=fb.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Um6e2AeF95rBDuI5ObtJ50Fz+nSiZDodnGjMNQnj9sc=; b=AVKK2ng8fNOMlRaPBG652TqSm 0CFgxX9X9Pfqt7eq16ga0ba9qnZN40lHMozf4SIjxoL3GyiW+/MZV3eMdr34b/8uK6OyPIxpG6pH1 f499+U3PubGtnJKIaFlaCeklUahugqCBpGvicLdbByFxa7kbmrH1EEvuSo4iEse4FV2xRRVRYdz9J ResRwvbLpzUmOL0Y0nnkQLZnGNMNJpru32tJjMmmPaELAKOgNtBE/4r5agxjGVWgRQrQhjKcbtUes NbGv1I4lHN1XRnKRSpEcCZ+ezBBvgeSN7Ozymxk3WYc4Tc4dywSJDKBYMnaYcgs1r1/iPWYcr5bvI UanIMQtdA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l7gYI-0002rN-F2; Thu, 04 Feb 2021 15:28:14 +0000 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l7gYF-0002qY-Nx for linux-nvme@lists.infradead.org; Thu, 04 Feb 2021 15:28:12 +0000 Received: from pps.filterd (m0044012.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 114FA0iM000302; Thu, 4 Feb 2021 07:27:53 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=subject : to : cc : references : from : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=facebook; bh=B0jPhiooojX+jQv2pQhdIvxdkllG0CT+N9CtaAkul7c=; b=iYiNBYb94LX/jdP6hWiGmw/8KG04SVfLBps2oB7EpC4OJk+bebTLi6wSEjt2ELr/A7EW wtaFeFXqUrBILYPDiQ50YpE0VsgRk0Vl7oDiYdWFoVFJTQWZl5Q7WX3ho2ERL9IVqx7z BNWk8HGc4F3ww0jMiN6Sd247ibIZElsfY90= Received: from maileast.thefacebook.com ([163.114.130.16]) by mx0a-00082601.pphosted.com with ESMTP id 36fwynem4s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Thu, 04 Feb 2021 07:27:53 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (100.104.31.183) by o365-in.thefacebook.com (100.104.36.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3; Thu, 4 Feb 2021 07:27:51 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FB9hSQw0UviZJoQZv6QeRV7m/NIZ8/7+Q+RcvPlIHXF6SmyHW8xiCUpHdGJlmLHCgsYqGCngAyzgKQcG9a42lyawS0qWxlM3DqWmQ5mCEYGS2W/1cGjR9fL8bu/Lk6wAcq1yrUPDvZ1m6tlNSwmrl5mtZXxmLMdN6rDSn4rbcPvqO9tlHiCvqb6/QIQeZzGUwEeWt4hWNGvyhw1o/umQWdKTRJBKNRIzGxd6/Ke7/l2ltL6yMQ2uZyzBhCFZGAIakb5UMCy9C89P446ZrPsES90QvzoyEDUY5dNBUkIIXp5GNgNj/AKVjRxCmhpGSIH9Snfg2LzIFeiJiRTBUkeJ5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B0jPhiooojX+jQv2pQhdIvxdkllG0CT+N9CtaAkul7c=; b=Kl8Mo6EjgAEm9ygOvEx1S269WofndmWSIG+RVFUcQvyPWWhXkx6r7tMLAk7hUNrKuZXH/650D2oka6Qt7YbXZGOLkr9DW/NPF4xo1kHLq5sGFhuZm8/u6YiRKWAtANb5HI0kmxs39hKQQd15V0FgcSmVIdGXyFJZvEoQXY86IIwz2W2UkY+MxV55iDopryQ8eMo9dttgTjGkZFAli/uKn5rETFCgm+uHHUFKIeVXFG8zQTys2o1pyKQWGZSuOl51tIpFyHC/H8WiLUjulb7BQicIy6h8UPKkWJo5ipfYJo1K47nNnVJgjikJLKgdzbLmdDYFiOmMbRRZggYuI+6ZfQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=fb.com; dmarc=pass action=none header.from=fb.com; dkim=pass header.d=fb.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.onmicrosoft.com; s=selector2-fb-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B0jPhiooojX+jQv2pQhdIvxdkllG0CT+N9CtaAkul7c=; b=TWE7tvKSZ3G3RJS5VLuT7zWsI4a0UFoVXm7sKklMo/AoFvnjOtr+WOPSJYnZ3YS/f/lWwK22TKj8t1ZKCm4nlM+yoMZQhkOf/+yuP5NpiksQR2c7kXrzSsc2X5UnFxZ05wm23dZaMNsS9FeEQ4D9H0kAemjHugJqilDhoaYMCYg= Authentication-Results: kernel.dk; dkim=none (message not signed) header.d=none;kernel.dk; dmarc=none action=none header.from=fb.com; Received: from BYAPR15MB2566.namprd15.prod.outlook.com (2603:10b6:a03:150::24) by SJ0PR15MB4233.namprd15.prod.outlook.com (2603:10b6:a03:2ec::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3825.17; Thu, 4 Feb 2021 15:27:50 +0000 Received: from BYAPR15MB2566.namprd15.prod.outlook.com ([fe80::684b:6f93:49d2:73eb]) by BYAPR15MB2566.namprd15.prod.outlook.com ([fe80::684b:6f93:49d2:73eb%6]) with mapi id 15.20.3784.023; Thu, 4 Feb 2021 15:27:50 +0000 Subject: Re: [PATCH v5 1/3] blk-mq: introduce blk_mq_set_request_complete To: Chao Leng , References: <20210201034940.18891-1-lengchao@huawei.com> <20210201034940.18891-2-lengchao@huawei.com> From: Jens Axboe Message-ID: <3b75b43c-638b-b5ac-eb5e-e37314d25ce1@fb.com> Date: Thu, 4 Feb 2021 08:27:46 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 In-Reply-To: <20210201034940.18891-2-lengchao@huawei.com> Content-Language: en-US X-Originating-IP: [65.144.74.34] X-ClientProxiedBy: CH0PR03CA0167.namprd03.prod.outlook.com (2603:10b6:610:ce::22) To BYAPR15MB2566.namprd15.prod.outlook.com (2603:10b6:a03:150::24) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.1.30] (65.144.74.34) by CH0PR03CA0167.namprd03.prod.outlook.com (2603:10b6:610:ce::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3825.20 via Frontend Transport; Thu, 4 Feb 2021 15:27:49 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b0ab1249-d574-4282-b87d-08d8c9216ec1 X-MS-TrafficTypeDiagnostic: SJ0PR15MB4233: X-Microsoft-Antispam-PRVS: X-FB-Source: Internal X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jhyZwvoJZLQzg2n1vAr98ObKiB7QuYegIeC0lypPoQ20e68GaS1EsHMKGF+DBY9otokMjni6MdzRsGN6VpzuIehXBuJpZ/HYwpUlpyO5ORWVKSV7NJV0UbmJK6jsWfNAIXOIC7XwFoq0x2gBE74pqk14vI6AcpzzbpnCh0d51zgvtbOgQV7lksO1FWEIznnRdFfx5gnttqOOeP1Ea97mnyV/3LQ+FvBG1j6TfAHIizE8FxjvyqHUeov4LRB4/2ciofP2X2Z4orZV5SWprzX6my64UmedYBIldsbNIKYF5/EDTpBmAHRPRlz7+xo4mK/8eMpk1BBjFvK1YjiL2ClU+4C2fGsAvS4wPkgOyeDHfyvegZLD97Mbtu5AvU2g7YEMG5aYEPgk0inbEKAfWE5l31OC7CGUlwEd2K7JpH+cbl2h5DsYl11R385bp2oCXHmrEVlbWuSUphYMjVdXZ0jmeUElKJ3Zw664/HvOH0znOCDOiHvfrWUZ6lJUponYgG24Oui06Z7g2AT73BS2dU5xcP/dBzjScCYY3W9f1m7vSOAiw8S/fSAcv9G/t9vhSCn3BKb7dcDoY+6/m2ZPXGnrdEDscti633KR7YlDPBAVvrI= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR15MB2566.namprd15.prod.outlook.com; PTR:; CAT:NONE; SFS:(39860400002)(136003)(366004)(346002)(376002)(396003)(52116002)(66556008)(316002)(66476007)(66946007)(16576012)(4744005)(5660300002)(4326008)(8676002)(6486002)(2906002)(86362001)(186003)(16526019)(2616005)(956004)(6666004)(36756003)(8936002)(53546011)(26005)(478600001)(83380400001)(31696002)(31686004)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?MER3V3MreHY3T0tDQmhWYlhSb0UwNHNiUC9XcGlZMWI1SXhKdXYvcmNOS2s3?= =?utf-8?B?eDhLeGpWelloYzhYMHdOdnNHemxVb2ZFNk5rRms2bFM1ZUZyYkx4TE5xV0Zr?= =?utf-8?B?OEJ6NUIwa292SFpsVFRZbzQzNGxnY0NvT2RBK3crZHhSbUNUMHhpZUluRTU3?= =?utf-8?B?RXV5eWI5TWdxWGpyQWNLWkl0MjZOMjdqcnFib0R2VzJ4dkU4RmUvRVltdUIv?= =?utf-8?B?QkZlZnR0eVhCZzYyelB1TWI2VVJMOWVZK00wclBDQlNpc1VESlNSNG5aMVJH?= =?utf-8?B?a0VRbURJZ3E1cUM5Y0VpYUFDWHg5NXltUnNuYy9lNFl3TUNxOFo4cHkvdGJ5?= =?utf-8?B?S3ZoeXlmTG8va0wzb0poVXcyZS9IWFAzejlUZjEyM3R1Tld3emZPenl1STFR?= =?utf-8?B?NTM2YzVNa3k4MFI2ZlowYUhQVmZSMDlxQjFvNWV4SnY2UExCUnZMcTU2emp3?= =?utf-8?B?a216azFoWGs5cGsyelMyUW1idjYxTEdsbGdUQzRDWElFOFdGOFhiQUFkTmp5?= =?utf-8?B?YmM1VXZSandSR1JEeEVRSG56c0tqcHhJYlpmRmNEbDVnMm8zZEpsanI4VFNz?= =?utf-8?B?UVV1TnJiaVdhbExDOHVaaUx2eDZSQkVzYngySnRqNU51ZXdzQk9uNnhvNVcw?= =?utf-8?B?OGNJSDgwZU9JY01Qa3dJZUp0ZkNxWm5PVktrM1J3d212MVBHSHBuTTFtamYw?= =?utf-8?B?bnliRzBiRG9YMGdMeWFhTnVWTys0NzJSMFlTOE5MKzFXU1NsdTl3Z2xNbGNx?= =?utf-8?B?YWg5dmJXS05jTXlFRU0zREdGQUtRWWVKSHgrSkVLbEk1aFMrWU5BVUFxUW1x?= =?utf-8?B?ZVZwQVovMUl6dGVaeFFtSjNRa2FUYUIwTXNuQVBIY0o2UHhhT3REVHNlZ1dr?= =?utf-8?B?YTRUaEI3K3NablNWK3RiVnFYcU54aUx5OTIzY0VPTkcvZzVWNERaL1dMMnZa?= =?utf-8?B?c0g5U3ZHOVR0ODh2SUtHOUd6eG5qcVU2cTZGRlNRdVQ2aWcyZDZ5bVNrSzVY?= =?utf-8?B?R0JWQU4walhJUjVadEtVV1pLeEt5WjdiRmhuS3pOZU1RMUVJS3M3TDFKdGl2?= =?utf-8?B?K0V6L0tESVpUVjlqdkJPdlJDOWtVU0huNDdST2p5c0VTVEhKa2o3TmtHSmRk?= =?utf-8?B?aEg3Ykhkb2lXeHNjeVNkaFlRN2h6YzllOXZicGh0OTBTSVNyRit5aW1nMW1o?= =?utf-8?B?WXlaemZxY3BFNU1CcER6RWdoeDlEWGxXMWtJM0JIV2xyVnFIbmRjN3EvRHZq?= =?utf-8?B?VUE5MVhrZWdKMDBQY1AxWU5jTUZVWFB6WDBoKzZWRmMzWWpvY2pvMWZiTmJx?= =?utf-8?B?VzZqSkVaK1JKeFRyYnNJQlREN0tsZGJ4Z3NpRFUyandMSzZMUkJieXNKNWx5?= =?utf-8?B?UzVzTm9XMW5hZTQ3dlp6SzRkMTZZT3VQOXBVajRvUTBGRTNtd1phbm5zR1Jm?= =?utf-8?Q?UMX91cqZ?= X-MS-Exchange-CrossTenant-Network-Message-Id: b0ab1249-d574-4282-b87d-08d8c9216ec1 X-MS-Exchange-CrossTenant-AuthSource: BYAPR15MB2566.namprd15.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2021 15:27:50.7835 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LCoaCzXugwLFVtqF+NpU0cGuonIo+R03RtZ+gHFw9kA8UXiYWa5U9c1AiZVUPlrK X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR15MB4233 X-OriginatorOrg: fb.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369, 18.0.737 definitions=2021-02-04_08:2021-02-04, 2021-02-04 signatures=0 X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 impostorscore=0 bulkscore=0 lowpriorityscore=0 spamscore=0 mlxscore=0 clxscore=1011 phishscore=0 suspectscore=0 adultscore=0 malwarescore=0 priorityscore=1501 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2102040099 X-FB-Internal: deliver X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210204_102812_030064_E966AE52 X-CRM114-Status: GOOD ( 13.21 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kbusch@kernel.org, linux-block@vger.kernel.org, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On 1/31/21 8:49 PM, Chao Leng wrote: > nvme drivers need to set the state of request to MQ_RQ_COMPLETE when > directly complete request in queue_rq. > So add blk_mq_set_request_complete. This is a bit iffy, but looks ok for the intended use case. We just have to be careful NOT to add frivolous users of it... -- Jens Axboe _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme