From: roy.shterman@gmail.com (roy)
Subject: [PATCH] nvme-rdma: Add debug message when reaches timeout
Date: Wed, 18 Oct 2017 14:17:26 +0300 [thread overview]
Message-ID: <3ba18b22-755f-0c72-9432-b6a2c09f712d@gmail.com> (raw)
In-Reply-To: <20171018074409.7483-1-nitzanc@mellanox.com>
On 18/10/17 10:44, Nitzan Carmi wrote:
> Signed-off-by: Nitzan Carmi <nitzanc at mellanox.com>
> Reviewed-by: Max Gurtovoy <maxg at mellanox.com>
> ---
> drivers/nvme/host/rdma.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c
> index 92a03ff..00c033e 100644
> --- a/drivers/nvme/host/rdma.c
> +++ b/drivers/nvme/host/rdma.c
> @@ -1582,6 +1582,10 @@ nvme_rdma_timeout(struct request *rq, bool reserved)
> {
> struct nvme_rdma_request *req = blk_mq_rq_to_pdu(rq);
>
> + dev_dbg_ratelimited(req->queue->ctrl->ctrl.device,
> + "Reached timeout - cid %d qid %d", rq->tag,
> + cpu_to_le16(nvme_rdma_queue_idx(req->queue)));
I guess cid is command id, I think it will be better to print the
nvme_command attributes.
something like
struct nvme_command *cmd = req->sqe.data;
and to print
cmd->common.command_id, cmd->common.opcode and the queue_id like you
printed.
Also why printing queue idx in little Indian format?
> +
> /* queue error recovery */
> nvme_rdma_error_recovery(req->queue->ctrl);
>
> --
> 2.9.4
>
>
> _______________________________________________
> Linux-nvme mailing list
> Linux-nvme at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2017-10-18 11:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-18 7:44 [PATCH] nvme-rdma: Add debug message when reaches timeout Nitzan Carmi
2017-10-18 10:44 ` Sagi Grimberg
2017-10-18 11:17 ` roy [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-10-20 8:24 Nitzan Carmi
2017-10-20 10:03 ` Christoph Hellwig
2017-10-22 9:37 Nitzan Carmi
2017-10-23 14:27 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ba18b22-755f-0c72-9432-b6a2c09f712d@gmail.com \
--to=roy.shterman@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).