From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>
Cc: Chaitanya Kulkarni <ckulkarnilinux@gmail.com>,
"hare@suse.de" <hare@suse.de>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH] nvme-auth: use IS_REACHABLE for nvme_auth_extract_key() declaration
Date: Mon, 3 Nov 2025 19:46:07 +0000 [thread overview]
Message-ID: <3bfea609-ad1b-422a-b070-9e9604777a8b@nvidia.com> (raw)
In-Reply-To: <aQjCQKiN5mzw2oY3@kbusch-mbp>
On 11/3/25 6:54 AM, Keith Busch wrote:
> On Mon, Nov 03, 2025 at 12:46:21PM +0100, Christoph Hellwig wrote:
>> So with Keith' latest fixes the auth code should always be built
>> in if either the host or target code is built in. Did this not
>> work, or is this for an older branch?
> It should be fine if either or both are built in. The problem is if both
> are modules. For that config, this should have used:
>
> #ifdef CONFIG_NVME_AUTH_STATE
>
> Or IS_REACHABLE also works.
>
unless there is a specific need to replace IS_REACHABLE() by
CONFIG_NVME_AUTH_STATE, can I please get Reviewed-by on this patch ?
-ck
next prev parent reply other threads:[~2025-11-03 19:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-02 3:17 [PATCH] nvme-auth: use IS_REACHABLE for nvme_auth_extract_key() declaration Chaitanya Kulkarni
2025-11-03 11:46 ` Christoph Hellwig
2025-11-03 14:54 ` Keith Busch
2025-11-03 19:46 ` Chaitanya Kulkarni [this message]
2025-11-03 20:16 ` Keith Busch
2025-11-03 20:28 ` Chaitanya Kulkarni
2025-11-03 21:12 ` Keith Busch
2025-11-03 19:43 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3bfea609-ad1b-422a-b070-9e9604777a8b@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=ckulkarnilinux@gmail.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox