From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Christoph Hellwig <hch@lst.de>
Cc: "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"kbusch@kernel.org" <kbusch@kernel.org>,
"sagi@grimberg.me" <sagi@grimberg.me>,
"james.smart@broadcom.com" <james.smart@broadcom.com>
Subject: Re: [PATCH 3/6] nvme-core: remove qid parameter
Date: Tue, 7 Jun 2022 06:04:40 +0000 [thread overview]
Message-ID: <3c512c62-0461-e1ef-8848-ade79ee8a7cb@nvidia.com> (raw)
In-Reply-To: <20220607055933.GA8927@lst.de>
On 6/6/22 22:59, Christoph Hellwig wrote:
> On Tue, Jun 07, 2022 at 05:57:02AM +0000, Chaitanya Kulkarni wrote:
>> On 6/6/22 21:39, Christoph Hellwig wrote:
>>> On Mon, Jun 06, 2022 at 06:16:44PM -0700, Chaitanya Kulkarni wrote:
>>>> We can easily derive the qid value from the nvme_command parameter of
>>>> the function __nvme_submit_sync_cmd() when its caller is
>>>> nvmf_connect_io_queue().
>>>
>>> This is a pretty horrible layering violation. The low-level submit
>>> helpers should no known about the contents of the payload.
>>
>> Okay, we can ignore this series then.
>
> The first patches still look good to me, though.
Well second patch also fixes the conditional operator without looking
at the contents of payload, perhaps we should consider that also if
it looks good.
-ck
next prev parent reply other threads:[~2022-06-07 6:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 1:16 [PATCH 0/6] nvme: __nvme_submit_sync_command() cleanup Chaitanya Kulkarni
2022-06-07 1:16 ` [PATCH 1/6] nvme-core: remove unused timeout parameter Chaitanya Kulkarni
2022-06-07 1:16 ` [PATCH 2/6] nvme-core: fix qid param blk_mq_alloc_request_hctx Chaitanya Kulkarni
2022-06-07 1:16 ` [PATCH 3/6] nvme-core: remove qid parameter Chaitanya Kulkarni
2022-06-07 4:39 ` Christoph Hellwig
2022-06-07 5:57 ` Chaitanya Kulkarni
2022-06-07 5:59 ` Christoph Hellwig
2022-06-07 6:04 ` Chaitanya Kulkarni [this message]
2022-06-07 1:16 ` [PATCH 4/6] nvme-core: remove flags parameter Chaitanya Kulkarni
2022-06-07 1:16 ` [PATCH 5/6] nvme-core: remove at_head parameter Chaitanya Kulkarni
2022-06-07 1:16 ` [PATCH 6/6] nvme-core: remove __nvme_submit_sync_cmd() wrapper Chaitanya Kulkarni
2022-06-13 18:15 ` [PATCH 0/6] nvme: __nvme_submit_sync_command() cleanup Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c512c62-0461-e1ef-8848-ade79ee8a7cb@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=hch@lst.de \
--cc=james.smart@broadcom.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox