From: Yi Zhang <yi.zhang@redhat.com>
To: Bart Van Assche <bvanassche@acm.org>, osandov@osandov.com
Cc: linux-block@vger.kernel.org, sagi@grimberg.me,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH blktests 1/5] tests/srp/rc: update the ib_srpt module name
Date: Wed, 25 Nov 2020 15:36:02 +0800 [thread overview]
Message-ID: <3cdec4ab-37af-b55a-377a-17f2362e4575@redhat.com> (raw)
In-Reply-To: <3e4208ef-3508-0db2-3b1d-96f055e1a37f@acm.org>
On 11/25/20 11:47 AM, Bart Van Assche wrote:
> On 11/24/20 6:01 AM, Yi Zhang wrote:
>> On 11/24/20 11:23 AM, Bart Van Assche wrote:
>>> On 11/23/20 5:04 PM, Yi Zhang wrote:
>>>> - insmod "/lib/modules/$(uname
>>>> -r)/kernel/drivers/infiniband/ulp/srpt/ib_srpt.ko" "${opts[@]}" ||
>>>> return $?
>>>> + insmod "$(ls /lib/modules/"$(uname
>>>> -r)"/kernel/drivers/infiniband/ulp/srpt/ib_srpt.*)" "${opts[@]}" ||
>>>> return $?
>>> Is 'ls' needed here or is 'echo' sufficient?
>> Actually it doesn't work without ls
>> $ insmod "/lib/modules/"$(uname
>> -r)"/kernel/drivers/infiniband/ulp/srpt/ib_srpt.*"
>> insmod: ERROR: could not load module
>> /lib/modules/5.10.0-rc5/kernel/drivers/infiniband/ulp/srpt/ib_srpt.*: No
>> such file or directory
>>
>> and it works with echo, I can change to echo if you prefer
>> $ insmod "$(echo /lib/modules/"$(uname
>> -r)"/kernel/drivers/infiniband/ulp/srpt/ib_srpt.*)" "${opts[@]}" ||
>> return $?
> 'echo' is a shell built-in while ls is not built-in into bash, so echo
> is faster.
yeah, thanks for the info.
> How about insmod "/lib/modules/$(uname
> -r)/kernel/drivers/infiniband/ulp/srpt/ib_srpt."* (no echo, no ls,
> asterisk outside double quotes)?
This works, have updated to V2
> Thanks,
>
> Bart.
>
>
> _______________________________________________
> Linux-nvme mailing list
> Linux-nvme@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-nvme
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-11-25 7:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 1:04 [PATCH blktests 0/5] nvmeof-mp/srp/nvme-rdma misc fix and enhancement Yi Zhang
2020-11-24 1:04 ` [PATCH blktests 1/5] tests/srp/rc: update the ib_srpt module name Yi Zhang
2020-11-24 3:23 ` Bart Van Assche
2020-11-24 14:01 ` Yi Zhang
2020-11-25 3:47 ` Bart Van Assche
2020-11-25 7:36 ` Yi Zhang [this message]
2020-11-24 1:04 ` [PATCH blktests 2/5] tests/nvmeof-mp/rc: run nvmeof-mp tests if we set multipath=N Yi Zhang
2020-11-24 3:26 ` Bart Van Assche
2020-11-24 14:04 ` Yi Zhang
2020-11-25 3:51 ` Bart Van Assche
2020-11-25 7:36 ` Yi Zhang
2020-11-24 1:04 ` [PATCH blktests 3/5] tests/nvmeof-mp/012: fix the schedulers list Yi Zhang
2020-11-24 3:28 ` Bart Van Assche
2020-11-24 14:06 ` Yi Zhang
2020-11-24 1:04 ` [PATCH blktests 4/5] common/rc: _have_iproute2 fix for "ip -V" change Yi Zhang
2020-11-24 3:29 ` Bart Van Assche
2020-11-24 14:07 ` Yi Zhang
2020-11-24 1:04 ` [PATCH blktests 5/5] common/multipath-over-rdma: allow to set use_siw Yi Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3cdec4ab-37af-b55a-377a-17f2362e4575@redhat.com \
--to=yi.zhang@redhat.com \
--cc=bvanassche@acm.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=osandov@osandov.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).