From: Hannes Reinecke <hare@suse.de>
To: Christoph Hellwig <hch@lst.de>
Cc: Sagi Grimberg <sagi@grimberg.me>,
Keith Busch <keith.busch@wdc.com>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH 2/3] nvmet: make the subsystem type configurable
Date: Tue, 5 Apr 2022 08:00:25 +0200 [thread overview]
Message-ID: <3d773039-ce36-277f-34c5-e0530567c4d3@suse.de> (raw)
In-Reply-To: <20220405054740.GD23466@lst.de>
On 4/5/22 07:47, Christoph Hellwig wrote:
> On Thu, Mar 17, 2022 at 03:26:33PM +0100, Hannes Reinecke wrote:
>> Make the subsystem type configurable to allow for unique
>> discovery subsystems by changing the subsystem type to
>> 'discovery'.
>
> Does it make sense to change the type? Or should we have a new top-level
> interface to create and configure discovery subsystems from the start?
>
> If we had e.g.
>
> /sys/kernel/config/nvmet/discovery-subsystems/
>
> we could start that out with a pre-filled well known discovery subsystem
> but also allow disabling that for example if we really want.
I actually looked into that with my previous attempt, and really found
no good way of having an entry which is
a) pre-filled
and
b) removable by the admin later on.
From what I've seen all pre-filled entries are static; I haven't found
a way to do pre-filled dynamic entries.
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
next prev parent reply other threads:[~2022-04-05 6:00 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-17 14:26 [PATCHv2 0/3] nvmet: unique discovery subsystem Hannes Reinecke
2022-03-17 14:26 ` [PATCH 1/3] nvmet: check for subsystem type in nvmet_find_get_subsys() Hannes Reinecke
2022-04-05 5:45 ` Christoph Hellwig
2022-04-05 5:53 ` Hannes Reinecke
2022-04-05 6:07 ` Christoph Hellwig
2022-04-05 13:06 ` John Meneghini
2022-03-17 14:26 ` [PATCH 2/3] nvmet: make the subsystem type configurable Hannes Reinecke
2022-04-05 5:47 ` Christoph Hellwig
2022-04-05 6:00 ` Hannes Reinecke [this message]
2022-04-05 6:09 ` Christoph Hellwig
2022-04-05 6:29 ` Hannes Reinecke
2022-04-05 10:35 ` Sagi Grimberg
2022-04-05 11:12 ` Hannes Reinecke
2022-04-05 15:02 ` John Meneghini
2022-04-05 13:15 ` John Meneghini
2022-03-17 14:26 ` [PATCH 3/3] nvmet: include all configured ports in discovery log page for unique discover controller Hannes Reinecke
2022-04-05 5:46 ` Christoph Hellwig
2022-04-05 6:15 ` Hannes Reinecke
2022-04-05 6:19 ` Christoph Hellwig
2022-04-05 6:35 ` Hannes Reinecke
2022-04-05 7:31 ` Christoph Hellwig
2022-04-05 10:32 ` Sagi Grimberg
2022-04-05 15:09 ` John Meneghini
2022-04-06 11:39 ` Hannes Reinecke
2022-04-05 10:41 ` Sagi Grimberg
2022-04-05 11:01 ` Hannes Reinecke
2022-04-05 14:22 ` Sagi Grimberg
-- strict thread matches above, loose matches on Subject: below --
2022-03-17 13:18 [PATCH 0/3] nvmet: unique discovery subsystem Hannes Reinecke
2022-03-17 13:18 ` [PATCH 2/3] nvmet: make the subsystem type configurable Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d773039-ce36-277f-34c5-e0530567c4d3@suse.de \
--to=hare@suse.de \
--cc=hch@lst.de \
--cc=keith.busch@wdc.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox