From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F2B4BC0218F for ; Wed, 29 Jan 2025 17:38:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:To:Subject:Cc:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pYh2yn40lkpaqAG8En7hcsBez+8JKaFCGsBWiD832tE=; b=REwDiRcMZs9mjz6wqaWlyXuh0S RLVxJsxjrzXxv5nF/RPiVHF0xY7lZ7Ab6nm0ZRGc/+yw/i+JulxPj4Y8eidV9wKt0nfnTJ1A4WAKH VsJVdBbQj0Ymv1hJy2+QO6zxHqKD+pNr8xIuFydGqB8RZfYFGTiwdVuSvPoWoQRjvnt3+Wbdv0wEk 8wtCtNOezMwGP0focEtpIxGk1I2mCgCwkf6R/AbL40ylmJ9YFvZYRABTOya4aHK7MvoidGvWDJYi9 hfZa08JsshWUOJtDiSiGSVW7lmpOIcp9L1np7CitYA8vqRkzRwMNwWYUJshrof+BEepCYUTLm+bcu eWUIacfw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tdC18-00000007Va2-1Q5w; Wed, 29 Jan 2025 17:38:22 +0000 Received: from linux.microsoft.com ([13.77.154.182]) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tdBcS-00000007Sh3-3Pvs; Wed, 29 Jan 2025 17:12:54 +0000 Received: from [100.65.130.94] (unknown [20.236.11.69]) by linux.microsoft.com (Postfix) with ESMTPSA id AC3D420591A1; Wed, 29 Jan 2025 09:12:50 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com AC3D420591A1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1738170772; bh=pYh2yn40lkpaqAG8En7hcsBez+8JKaFCGsBWiD832tE=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=Rak3F2+8fD36df/6R9W6FIe4vLPlHDgpiHFKAtGMBHH6D5mOcR2hxxoOHOyUlYT1e yDP0p8wAmOL/TcaLg32uBJFdZTn7tWe8PR5xNYjJ+B3J6emo7glJ0gq+pyY27z7ZrW RsCXOpUAqjEEHyM/3gJpHfkTqWPKNwTSH7U1jcB0= Message-ID: <3e4a8a44-483b-457a-b193-4119e4adfa85@linux.microsoft.com> Date: Wed, 29 Jan 2025 09:12:53 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: eahariha@linux.microsoft.com, Andrew Morton , Yaron Avizrat , Oded Gabbay , Julia Lawall , Nicolas Palix , James Smart , Dick Kennedy , "James E.J. Bottomley" , "Martin K. Petersen" , Jaroslav Kysela , Takashi Iwai , Chris Mason , Josef Bacik , David Sterba , Ilya Dryomov , Dongsheng Yang , Jens Axboe , Xiubo Li , Damien Le Moal , Niklas Cassel , Carlos Maiolino , "Darrick J. Wong" , Sebastian Reichel , Keith Busch , Sagi Grimberg , Frank Li , Mark Brown , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Shyam Sundar S K , Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Henrique de Moraes Holschuh , Selvin Xavier , Kalesh AP , Jason Gunthorpe , Leon Romanovsky , cocci@inria.fr, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-sound@vger.kernel.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, linux-block@vger.kernel.org, linux-ide@vger.kernel.org, linux-xfs@vger.kernel.org, linux-pm@vger.kernel.org, linux-nvme@lists.infradead.org, linux-spi@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, platform-driver-x86@vger.kernel.org, ibm-acpi-devel@lists.sourceforge.net, linux-rdma@vger.kernel.org Subject: Re: [PATCH 09/16] xfs: convert timeouts to secs_to_jiffies() To: Christoph Hellwig References: <20250128-converge-secs-to-jiffies-part-two-v1-0-9a6ecf0b2308@linux.microsoft.com> <20250128-converge-secs-to-jiffies-part-two-v1-9-9a6ecf0b2308@linux.microsoft.com> <20250129052108.GB28513@lst.de> From: Easwar Hariharan Content-Language: en-US In-Reply-To: <20250129052108.GB28513@lst.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250129_091252_876842_97303948 X-CRM114-Status: GOOD ( 10.27 ) X-Mailman-Approved-At: Wed, 29 Jan 2025 09:38:17 -0800 X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On 1/28/2025 9:21 PM, Christoph Hellwig wrote: > On Tue, Jan 28, 2025 at 06:21:54PM +0000, Easwar Hariharan wrote: >> else >> - cfg->retry_timeout = msecs_to_jiffies( >> - init[i].retry_timeout * MSEC_PER_SEC); >> + cfg->retry_timeout = secs_to_jiffies(init[i].retry_timeout); > > This messes up the formatting by introducing an overly long line. > > Otherwise the change looks fine. I'll fix this in v2. Thanks for the review! - Easwar (he/him)