From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7095DC04FFE for ; Sat, 11 May 2024 09:13:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UE4InP61OxD+l8jmkYdUmsijattPNEVP+SewgNel8uk=; b=qdCHPC7jZRZRxJuLacOTPiiQEr rArLzp1/vIdgemJJaCLgi5T1xobLnJbhz/35nG44+IEqPQMbCPXyBQRZA+kXqhXCZQl6001dxmZBV sV8j6Ke1KHK8IHwhQb4bgjeMDPGS7clABGdB8ll3DwtPYgKq0dHj1ceN6dJqmmRYW6VORsUJk+RqC 4cn6SA079LSzRK8BBCsOKodxJvNuvyGCS1vv4jdIut+UmrtVF8ObQ4/jOQHuyc0/EuNv/ompL9i4z zIPem+GYKoLtJqVVln+ZPd2rGMh3dhNdcfhmApRqrueKkLNl8puYgd0mK9Uk+EM7+rL2x0fm9Ax6n hHGjVzjw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s5inC-00000007bKR-44Nn; Sat, 11 May 2024 09:13:22 +0000 Received: from smtp-out2.suse.de ([195.135.223.131]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s5in7-00000007bIw-3sgD for linux-nvme@lists.infradead.org; Sat, 11 May 2024 09:13:20 +0000 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 862FC20B6A; Sat, 11 May 2024 09:13:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1715418795; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UE4InP61OxD+l8jmkYdUmsijattPNEVP+SewgNel8uk=; b=OojacKkzxvOiyzxIpsmZsH+AFH4mYHjQJCMDw5zGtTRSA7e74BDrt5mN+Tt5Ja66b5XH1N Q/eUKsa6F1kLYBnNiYGMa2/u23G+CX6/c9ZWJHdZl4LjKFszZeEwUReaHnNPmJy8UoOXKU cYoXyPoqKgDZkWQmI87ndWcb9T22fPM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1715418795; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UE4InP61OxD+l8jmkYdUmsijattPNEVP+SewgNel8uk=; b=rimIeH5pn1icjr5UoU3kF92Sf+tcdG83e5jdYYgk1rAg3lrambnOj9swvvj+ZxxVp9ZKvu wO1HpfHwq7nmzCAw== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=OojacKkz; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=rimIeH5p DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1715418795; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UE4InP61OxD+l8jmkYdUmsijattPNEVP+SewgNel8uk=; b=OojacKkzxvOiyzxIpsmZsH+AFH4mYHjQJCMDw5zGtTRSA7e74BDrt5mN+Tt5Ja66b5XH1N Q/eUKsa6F1kLYBnNiYGMa2/u23G+CX6/c9ZWJHdZl4LjKFszZeEwUReaHnNPmJy8UoOXKU cYoXyPoqKgDZkWQmI87ndWcb9T22fPM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1715418795; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UE4InP61OxD+l8jmkYdUmsijattPNEVP+SewgNel8uk=; b=rimIeH5pn1icjr5UoU3kF92Sf+tcdG83e5jdYYgk1rAg3lrambnOj9swvvj+ZxxVp9ZKvu wO1HpfHwq7nmzCAw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 2552C13A3E; Sat, 11 May 2024 09:13:15 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap1.dmz-prg2.suse.org with ESMTPSA id 4NvgA6s2P2Y9JwAAD6G6ig (envelope-from ); Sat, 11 May 2024 09:13:15 +0000 Message-ID: <3e6bbc4a-c1ed-4460-a266-3d4b0fdbb9c6@suse.de> Date: Sat, 11 May 2024 11:13:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/5] fs/mpage: avoid negative shift for large blocksize Content-Language: en-US To: Matthew Wilcox , hare@kernel.org Cc: Andrew Morton , Pankaj Raghav , Luis Chamberlain , linux-nvme@lists.infradead.org, linux-block@vger.kernel.org References: <20240510102906.51844-1-hare@kernel.org> <20240510102906.51844-3-hare@kernel.org> From: Hannes Reinecke In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Rspamd-Queue-Id: 862FC20B6A X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-4.50 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; XM_UA_NO_VERSION(0.01)[]; RCPT_COUNT_SEVEN(0.00)[7]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:email]; DKIM_TRACE(0.00)[suse.de:+] X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240511_021318_163287_D6B97E22 X-CRM114-Status: UNSURE ( 7.58 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On 5/11/24 00:24, Matthew Wilcox wrote: > On Fri, May 10, 2024 at 12:29:03PM +0200, hare@kernel.org wrote: >> - block_in_file = (sector_t)folio->index << (PAGE_SHIFT - blkbits); >> + block_in_file = (sector_t)(((loff_t)folio->index << PAGE_SHIFT) >> blkbits); > > block_in_file = folio_pos(folio) >> blkbits; > > I know there was a better way. Will be fixing it up. Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich