From: Kanchan Joshi <joshi.k@samsung.com>
To: Tokunori Ikegami <ikegami.t@gmail.com>, linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme: initialize identify ns data to NULL
Date: Tue, 26 Mar 2024 19:32:38 +0530 [thread overview]
Message-ID: <3efcf01d-e83a-e5ad-d335-7516b857eef0@samsung.com> (raw)
In-Reply-To: <a92a1493-29ae-4f89-b17b-54d03ec0becc@gmail.com>
On 3/26/2024 7:08 PM, Tokunori Ikegami wrote:
>
> On 2024/03/26 17:50, Kanchan Joshi wrote:
>> On 3/25/2024 9:15 PM, Tokunori Ikegami wrote:
>>> Currently nvme_identify_ns() sets the data to NULL if failed.
>>> Also the data is not freed if the function returned failure.
>> If it fails, it frees the allocated memory too.
>> So I don't see how the patch helps.
> Yes I think this just helps if in future thenvme_identify_ns() function
> or the caller functions changed the implementation.
Not a compelling case of future convenience, IMHO.
In the current scheme of things, the assignment to NULL in all the
callers of nvme_identify_ns (there are few more than what this patch
covered) is redundant.
next prev parent reply other threads:[~2024-03-26 14:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240325154544epcas5p4acf7f376241637872a433314489586fa@epcas5p4.samsung.com>
2024-03-25 15:45 ` [PATCH] nvme: initialize identify ns data to NULL Tokunori Ikegami
2024-03-26 8:20 ` Sagi Grimberg
2024-03-26 13:35 ` Tokunori Ikegami
2024-03-26 8:50 ` Kanchan Joshi
2024-03-26 13:51 ` Tokunori Ikegami
[not found] ` <a92a1493-29ae-4f89-b17b-54d03ec0becc@gmail.com>
2024-03-26 14:02 ` Kanchan Joshi [this message]
2024-03-26 14:56 ` Tokunori Ikegami
2024-03-26 15:37 ` Keith Busch
2024-03-26 15:54 ` Tokunori Ikegami
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3efcf01d-e83a-e5ad-d335-7516b857eef0@samsung.com \
--to=joshi.k@samsung.com \
--cc=ikegami.t@gmail.com \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox