From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Sagi Grimberg <sagi@grimberg.me>, "hch@lst.de" <hch@lst.de>
Cc: "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
Keith Busch <kbusch@kernel.org>,
Guixin Liu <kanie@linux.alibaba.com>
Subject: Re: [PATCH v7 1/1] nvmet: support reservation feature
Date: Thu, 21 Mar 2024 08:06:28 +0000 [thread overview]
Message-ID: <412afde6-db7c-450b-b8d8-bd461b4d7b72@nvidia.com> (raw)
In-Reply-To: <ef50ec40-dc7f-42fd-b84d-c0842a8392b4@grimberg.me>
On 3/20/2024 2:16 AM, Sagi Grimberg wrote:
>
>
> On 20/03/2024 3:59, hch@lst.de wrote:
>> On Tue, Mar 19, 2024 at 11:19:50AM +0800, Guixin Liu wrote:
>>> I am adding a per-controller percpu-ref to ns to implement
>>> preempt_and_abort, the v9 will be soon.
>> Do we need that? For blk-mq based backends just doing a queue freeze
>> would be enough. That doesn't work for bio based drivers yet, but I'd
>> rather improve the block layer freezing for them rather than reimplenting
>> the whole thing.
>
> That's a neat idea, we also have file to think about though.
I failed to understand how this will work for non block device
(passthru or bio mode) backend(s). Unless there is a plan to create
similar API for non block device backhend(s) and if that turns out to be
overkill then why not go with current per-controller percpu-ref ?
-ck
next prev parent reply other threads:[~2024-03-21 8:06 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-01 2:32 [PATCH v7 0/1] Implement the NVMe reservation feature Guixin Liu
2024-02-01 2:32 ` [PATCH v7 1/1] nvmet: support " Guixin Liu
2024-02-28 0:40 ` Sagi Grimberg
2024-02-28 2:21 ` Guixin Liu
2024-02-28 3:21 ` Keith Busch
2024-02-28 3:40 ` Guixin Liu
2024-03-07 9:27 ` Sagi Grimberg
2024-03-07 9:42 ` Guixin Liu
2024-03-08 9:15 ` Guixin Liu
2024-03-08 10:07 ` Sagi Grimberg
2024-03-11 11:19 ` Guixin Liu
2024-03-12 21:31 ` Sagi Grimberg
2024-03-13 3:42 ` Guixin Liu
2024-03-13 9:54 ` Sagi Grimberg
2024-03-13 11:56 ` Guixin Liu
2024-03-13 12:36 ` Sagi Grimberg
2024-03-14 2:03 ` Guixin Liu
2024-03-19 2:59 ` Chaitanya Kulkarni
2024-03-19 3:19 ` Guixin Liu
2024-03-20 1:59 ` hch
2024-03-20 9:16 ` Sagi Grimberg
2024-03-21 8:06 ` Chaitanya Kulkarni [this message]
2024-03-21 21:02 ` hch
2024-03-22 9:34 ` Chaitanya Kulkarni
2024-03-23 20:41 ` Sagi Grimberg
2024-02-18 2:12 ` [PATCH v7 0/1] Implement the NVMe " Guixin Liu
2024-02-26 6:33 ` Guixin Liu
2024-02-26 6:43 ` Chaitanya Kulkarni
2024-02-29 2:57 ` Guixin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=412afde6-db7c-450b-b8d8-bd461b4d7b72@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=hch@lst.de \
--cc=kanie@linux.alibaba.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox